Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle tokens that prevent zero transfer #993

Open
EndymionJkb opened this issue Sep 19, 2024 · 0 comments · May be fixed by #1014
Open

Handle tokens that prevent zero transfer #993

EndymionJkb opened this issue Sep 19, 2024 · 0 comments · May be fixed by #1014
Assignees

Comments

@EndymionJkb
Copy link
Collaborator

Per auditor comment (and we know this from v1/v2), some tokens can't handle zero value transfers. While most of the time this is checked (often as a gas optimization), there are places where it's not. We don't need to do it for WETH or BPT, but any time there is an unknown "pool token," we can ensure transfers are non-zero.

Hopefully it will be mostly a wash as far as gas. The checks take some time, but we're also avoiding zero transfers.

@EndymionJkb EndymionJkb self-assigned this Sep 19, 2024
@EndymionJkb EndymionJkb linked a pull request Sep 26, 2024 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant