agETH Rate Provider #133
Closed
agETH Rate Provider #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #131
|
Review was pending finalization due to the request for downstream loan contracts related to agETH. Likely from the loanDeployer Kelp response: We can provide the Abi for this contract. Due to the institutional nature of this contract, I heard back that it can’t be verified publicly. @mkflow27 @danielmkm is this acceptable or would we like to put a frontend warning for these cases. Something along the lines of the rate provider contract being compatible with our contracts, but the project team opts for periphery contracts to remain unverified and are not included in this review. Therefore there can be underlying unknown risks. |
|
Closing this and moving ag ETH to new registry structure here #157. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #131
Outstanding activities