-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eBTC Rate Provider #145
base: main
Are you sure you want to change the base?
eBTC Rate Provider #145
Conversation
Fixes #134
@Zen-Maxi Similar question as in the weETHs pr here: https://github.com/balancer/code-review/pull/94/files#diff-094145a04738e17e78f688615c745a3c99c80cc944fa47b274ad928bdcd68f39R93 #94 Ideally the rateProvider utilises |
@Zen-Maxi Could you verify with the team the following observation. Based on this txHash 0xb21d447fbaa73159d20cc2ecc508e224cdd66e41378601001af09308f3df16c0 It is indicated that Role "11" is allowed to call
if I investigate which accounts have been given which role by looking at all |
Will hold off on the review here until we get an update. |
Yes I think using |
The UPDATE_EXCHANGE_RATE_ROLE is currently granted to eth:0x41DFc53B13932a2690C9790527C1967d8579a6ae and eth:0x71E2d6c34f569cC4Df5802d675B208FB8AE3Bcd6. Though for the mean time this would only be used for emergencies. In the future when eigen layer is emitting rewards the exchange rate is likely to increase though. |
Adapter contract https://etherscan.io/address/0xa517584dec22d71797ca9a6fda6f947d7aeafe8b#readContract deployed by Veda team. This reads getRateSafe from the original deployment and returns it as getRate in order to utilize the safety thresholds. Please review and update conclusion if this is sufficient for use.
Fixes #134
Outstanding activities:
Outstanding activities: