Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected deprecation message on Model.watch() #3563

Closed
ljacques opened this issue Feb 10, 2016 · 2 comments
Closed

Unexpected deprecation message on Model.watch() #3563

ljacques opened this issue Feb 10, 2016 · 2 comments
Labels
inconsistency sockets Relates to sails.sockets.* or resourceful pubsub (RPS) methods, sails.io.js, or sockets in general

Comments

@ljacques
Copy link

Model.watch(req) print a debug message :

debug: sails.sockets.id() is deprecated; use sails.sockets.getId() (see http://sailsjs.org/documentation/concepts/upgrading/to-v-0-12)

@mikermcneil
Copy link
Member

Thanks @ljacques - there's a fix in place on master and we'll be removing this message in a patch release this week (.watch() formerly called .id() instead of .getId() and we forgot to switch it over during the upgrade. The only reason for the name change was to make the behavior clearer, and .id() is just an alias- so there's nothing to worry about in the mean time).

@mikermcneil mikermcneil added bug inconsistency sockets Relates to sails.sockets.* or resourceful pubsub (RPS) methods, sails.io.js, or sockets in general patched-on-master and removed bug labels Feb 10, 2016
@mikermcneil mikermcneil changed the title watch Unexpected deprecation message on Model.watch() Feb 10, 2016
@ljacques
Copy link
Author

Thanks @mikermcneil
I keep testing ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inconsistency sockets Relates to sails.sockets.* or resourceful pubsub (RPS) methods, sails.io.js, or sockets in general
Development

No branches or pull requests

2 participants