Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to allow a new release to be created if finalize does not find a matching commit #102

Open
klutchell opened this issue Feb 7, 2022 · 0 comments

Comments

@klutchell
Copy link
Collaborator

klutchell commented Feb 7, 2022

An example I've seen many times in my personal repos:

  1. PR opened by non-owner (user fork, dependabot, etc)
  2. Deploy-to-balena action fails or is skipped as GH secrets are not available (API token, etc)
  3. PR is merged anyway cause the code looks good
  4. Finalize fails as no matching release exists

Why not add a new boolean flag to push a final release as a fallback for step 4 , or a more dynamic workflow param?

  • workflow: draft - always push draft releases, and finalize on merge to master (current behaviour)
  • workflow: auto - on merge/push to master check for existing release to finalize, otherwise push a new final release
  • workflow: final - always push a new final release, from any branch

I know you have discussed workflows ad nauseam but I think this provides a really flexible alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant