Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can not to build on MS-Windows #3292

Closed
btwise opened this issue Aug 31, 2020 · 2 comments · Fixed by #4132
Closed

can not to build on MS-Windows #3292

btwise opened this issue Aug 31, 2020 · 2 comments · Fixed by #4132

Comments

@btwise
Copy link

btwise commented Aug 31, 2020 •
edited
Loading

  • **Etcher version:1.5.102+
  • **Operating system and architecture:win10

Tiffutil is a macOS program. When packaged on Windows using make electron-build, the error message that tiffutil cannot be found appears!
@lurch
Copy link
Contributor

lurch commented Sep 1, 2020

Looking at the Makefile it seems like electron-build is unconditionally depending on assets/dmg/background.tiff (and tiffutil is needed to make background.tiff).
However I guess electron-build should probably only depend on assets/dmg/background.tiff when the $(PLATFORM) is darwin ? 🤷‍♂️

Hmmm, although background.tiff does already exist in https://github.com/balena-io/etcher/tree/master/assets/dmg so in theory there should be no need to re-make it?

@thundron
Copy link
Contributor

I built fine on Windows following the contributing file and while it misses some things, I had no issues with cross-platform packages.
What error do you see when building?

@dfunckt dfunckt mentioned this issue Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modernize build pipeline balena-io/etcher
3 participants
@lurch @thundron @btwise