Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.resinci.json missing, but still needed for make electron-build #4136

Closed
NotizMe opened this issue Nov 13, 2023 · 0 comments · Fixed by #4132
Closed

.resinci.json missing, but still needed for make electron-build #4136

NotizMe opened this issue Nov 13, 2023 · 0 comments · Fixed by #4132

Comments

@NotizMe
Copy link

NotizMe commented Nov 13, 2023

  • Etcher version: v1.18.12 and v1.18.13
  • Operating system and architecture: Kubuntu 23.10 x64
  • Image flashed: N/A
  • Reproduction process:
git clone [email protected]:balena-io/etcher.git
cd etcher
make electron-develop
make electron-build
  • What do you think should have happened: deb, rpm and appImage should build
  • What happened:
mkdir dist
mkdir dist/.tmp
./scripts/resin/electron/build.sh \
        -b /home/pieter/code/etcher \
        -r x64 \
        -s linux \
        -v production \
        -n dist/.tmp/npm
node:internal/modules/cjs/loader:1080
  throw err;
  ^

Error: Cannot find module '/home/pieter/code/etcher/.resinci.json'
Require stack:
- /home/pieter/code/etcher/scripts/resin/electron/extend-electron-builder-config.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1077:15)
    at Module._load (node:internal/modules/cjs/loader:922:27)
    at Module.require (node:internal/modules/cjs/loader:1143:19)
    at require (node:internal/modules/cjs/helpers:119:18)
    at Object.<anonymous> (/home/pieter/code/etcher/scripts/resin/electron/extend-electron-builder-config.js:39:32)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:86:12) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/pieter/code/etcher/scripts/resin/electron/extend-electron-builder-config.js'
  ]
}

Node.js v18.18.2
make: *** [Makefile:105: electron-build] Error 1
  • Do you see any meaningful error information in the DevTools? N/A

Extra info

Currently, my workaround is checking out the latest version of .resinci.json

git checkout 292f86d6f5b0e8dd34cb3dd6e008517f9a066cd0 .resinci.json

I'm not familiar with this codebase. It seems that the build procedure has been updated at some point, which made .resinci.json obsolete. But make electron-build still uses the old build method and needs .resinci.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant