Fix the invalid error for readonly record types #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SasinduDilshara
requested review from
gimantha,
MaryamZi and
hasithaa
as code owners
lnash94
reviewed
Oct 11, 2024
MaryamZi
reviewed
Oct 11, 2024
native/src/main/java/io/ballerina/lib/data/jsondata/json/JsonParser.java
Show resolved
Hide resolved
| ReadOnlyUser r = check parseString(user); | ||
| test:assertEquals(r, {id: 4012}); | ||
| } | ||
|
|
There was a problem hiding this comment.
Can we add more tests with
- members of selectively-immutable types that become immutable because the type it is in is immutable - e.g., like the
idfield, but with a selectively-immutable type - field of a readonly intersection type in a mutable type
There was a problem hiding this comment.
Added tests for these scenarios.
There was a problem hiding this comment.
Can you please point to the relevant tests for each of these cases?
lnash94
reviewed
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes: ballerina-platform/ballerina-library#7253
Fixes: ballerina-platform/ballerina-library#7254
Examples
Checklist