Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for POL Contract #109

Closed
9 of 12 tasks
Lesigh-3100 opened this issue Sep 4, 2023 · 0 comments
Closed
9 of 12 tasks

Add support for POL Contract #109

Lesigh-3100 opened this issue Sep 4, 2023 · 0 comments
Assignees
@mikewcasale @Lesigh-3100
Labels
enhancement New feature or request priority-high

Comments

@Lesigh-3100
Copy link
Collaborator

Lesigh-3100 commented Sep 4, 2023 •
edited
Loading

Subtasks

  • Preprocessing - Add exchange’s pool metadata
  • Preprocessing - Add contract addresses
  • Data gathering - Create exchange class
  • Data gathering - Create pool Class
  • Data gathering - Add exchange ABIs
  • Data gathering - Add trade event structure
  • Data gathering - Add custom handling for exchange
  • Transaction handling - custom inputs
  • Arb Contract - integrate exchange

Bugs

  • Data gathering - the token balances need to come from calling the tokenContract.balanceOf(CarbonPOL.address) at least on the first run of the bot (currently using token prices)
  • Run - in main.py you are sending handle_replay_from_block the polling_interval instead of the replay_from_block
  • Data gathering - prices need to be encoded if you are handling them exactly like carbon orders
@Lesigh-3100 Lesigh-3100 added enhancement New feature or request priority-high labels Sep 4, 2023
@Lesigh-3100 Lesigh-3100 self-assigned this Sep 4, 2023
@mikewcasale mikewcasale self-assigned this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikewcasale mikewcasale

@Lesigh-3100 Lesigh-3100

Labels
enhancement New feature or request priority-high
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

109-add-support-for-pol-contract bancorprotocol/fastlane-bot
2 participants
@mikewcasale @Lesigh-3100