Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max priority fee overridden in build_transaction_with_gas when gas base fee fails #300

Closed
Lesigh-3100 opened this issue Jan 15, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Lesigh-3100
Copy link
Collaborator

Bug Description

In txhelpers.py, in the function build_transaction_with_gas, the max priority fee is overridden in the first except. The original max priority set should be used.

Severity (High/Medium/Low)

Low

Steps to Reproduce

Run the bot & when it has an error with the base priority fee, the max priority is overridden.

Expected Behavior

The transaction should use the input max priority.

Actual Behavior

The transaction uses a max priority from a value in the error message.

Impact Analysis (to be filled by contributors)

  • Automated Tests: A test would be good to cover this & our handling of error messages.
  • Risks: Low risk - the bot still operates with this bug
  • Performance: No
  • Monitoring: No
  • Logging: No
  • Documentation: No
@Lesigh-3100 Lesigh-3100 added the bug Something isn't working label Jan 15, 2024
@Lesigh-3100 Lesigh-3100 self-assigned this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant