Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max priority fee input overridden when handling incorrect base fee input error #307

Closed
Lesigh-3100 opened this issue Jan 16, 2024 · 0 comments · Fixed by #308
Closed

Max priority fee input overridden when handling incorrect base fee input error #307

Lesigh-3100 opened this issue Jan 16, 2024 · 0 comments · Fixed by #308
Assignees
Labels
bug Something isn't working

Comments

@Lesigh-3100
Copy link
Collaborator

Bug Description

In TxHelpers, when we handle the error of an incorrect base fee, we override the max priority fee. This should, however, still use the max_priority input into the function.

Severity (High/Medium/Low)

Low

Steps to Reproduce

Run bot until base fee error - print the overridden max priority fee

Expected Behavior

max_priority input into the function should be used consistently

Actual Behavior

max_priority is overridden & can be doubled or more as a result

Impact Analysis (to be filled by contributors)

  • Automated Tests: No tests that cover this.
  • Risks:
  • This should be isolated to TX submission.
  • Performance: No
  • Monitoring: No
  • Logging: No
  • Documentation: No
@Lesigh-3100 Lesigh-3100 added the bug Something isn't working label Jan 16, 2024
@Lesigh-3100 Lesigh-3100 self-assigned this Jan 16, 2024
@Lesigh-3100 Lesigh-3100 linked a pull request Jan 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant