Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we add Object.assign polyfill to client.tsx? #144

Open
bherila opened this issue Jun 28, 2017 · 2 comments
Open

Should we add Object.assign polyfill to client.tsx? #144

bherila opened this issue Jun 28, 2017 · 2 comments

Comments

@bherila
Copy link
Contributor

bherila commented Jun 28, 2017

per https://stackoverflow.com/questions/35215360/getting-error-object-doesnt-support-property-or-method-assign, this adds IE11 support.
@TriStarGod
Copy link

Won't typescript handle this based on your target minimum browser javascript support? Its set to es6 atm.

@bherila
Copy link
Contributor Author

bherila commented Jul 3, 2017

Typescript does not polyfill Object.assign, and as discussed in #139, setting Typescript to ES6 mode causes problems with Babel transpilation from ES6 ->ES5.

The recommendation from @OR13 was to set Typescript to ES5 but then we have this Object.assign issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bherila @TriStarGod