Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdaptiveHorizontalCover not using height_awning #175

Closed
3 tasks done
mion00 opened this issue May 24, 2024 · 1 comment · Fixed by #199
Closed
3 tasks done

AdaptiveHorizontalCover not using height_awning #175

mion00 opened this issue May 24, 2024 · 1 comment · Fixed by #199

Comments

@mion00
Copy link
Contributor

mion00 commented May 24, 2024

What version of Adaptive Cover are you using?

1.2.0

What version of Home Assistant are you using?

2024.5

Checklist

  • I have filled out the issue template to the best of my ability.
  • This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
  • This issue is not a duplicate issue of currently previous issues..

Describe the issue

From the source code, it seems as if the config entry height_awning is not used in any way by the AdaptiveHorizontalCover.
Maybe it was used in a previous version of the calculation.py?

Reproduction steps

Searched the source code for reference to the CONF_HEIGHT_AWNING constant.

Diagnostics dump

No response

@basbruss
Copy link
Owner

Thanks for mentioning this, I will take a closer look at in when I have more time. It could be that the value used in the calculation is not correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants