Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malaysia & Indonesia Prayer Times #62

Closed
farisfaisalthena opened this issue Mar 21, 2021 · 6 comments
Closed

Malaysia & Indonesia Prayer Times #62

farisfaisalthena opened this issue Mar 21, 2021 · 6 comments

Comments

@farisfaisalthena
Copy link

Hi there,

I was just curious is there any calculations method for JAKIM? Because I tried using

    const coordinates = new adhan.Coordinates(2.926361, 101.696445);
    const date = new Date();
    const params = adhan.CalculationMethod.UmmAlQura();
    const time = new adhan.PrayerTimes(coordinates, date, params);

But i always get a few minutes earlier/later. Besides that I would also like to know what calculations are used for Malaysia and Indonesia. Thank you

@sgtsquiggs
Copy link
Contributor

Was looking at this - I can't reconcile our code with what JAKIM is calculating. The fajr, isha offsets should be 20, 18 (Singapore calc method does this) but there's something else as well that I'm missing.

Going by the most official prayer times I could find: https://muftiwp.gov.my/images/falak/takwim/jadual-waktu-solat/KL-dan-Putrajaya/Jadual-Waktu-Solat-WPKL-PTJ-2021.pdf

I'll have to dig a bit more.

@farisfaisalthena
Copy link
Author

Hello there,

So i believe there’s an issue right? Also the same with Indonesia praying time not being accurate

@z3bi
Copy link
Contributor

z3bi commented Mar 22, 2021

@farisfaisalthena using the singapore method in the library will get you pretty close, we are working on adding a JAKIM method soon inshAllah that should match the times exactly.

@farisfaisalthena
Copy link
Author

Hi, thank you for answering. I will just wait until JAKIM is added as my users might complain not being accurate etc. Also would be great if you could add "Sihat/Kemenag" calculation method for Indonesia, would highly appreciate that. For JAKIM here are some sites i found that might help you with the implementation https://khaliqhalid.my/2018/02/malaysia-muslim-praying-time-api/ and https://github.com/afzafri/Waktu-Solat-API. Great job so far and stay safe!

@z3bi
Copy link
Contributor

z3bi commented Mar 22, 2021

@farisfaisalthena upon further investigation the reason our singapore method has a discrepancy is because the official times in Malaysia are centralized in different zones. If you use the coordinates provided in this document you will find that our times are only off by about 1 minute (which is most likely due to rounding - something we hope to fix in #43) https://www.e-solat.gov.my/portalassets/files/Lampiran%20B.pdf

@farisfaisalthena
Copy link
Author

Yup there just off but would be great in future to have JAKIM calculation to provide a more accurate info 👍

@z3bi z3bi closed this as completed Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants