Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: support NuGet Central Package Management lock files #444

Open
hcoona opened this issue Jun 27, 2024 · 7 comments
Open

Proposal: support NuGet Central Package Management lock files #444

hcoona opened this issue Jun 27, 2024 · 7 comments

Comments

@hcoona
Copy link

hcoona commented Jun 27, 2024

NuGet Central Package Management can generate lock files, see Enable repeatable package restores using a lock file.

Considered the well integration with Visual Studio and broadly adoption, I propose our rules_dotnet support NuGet.

@tomdegoede
Copy link
Collaborator

When working on this this we definitely took this as first direction. Unfortunately the hash in the NuGet lockfile turned out differ from the file hash of the downloaded nupkg which made it incompatible with Bazel's download logic. If this has changed now I'm keen to implement this.

@hcoona
Copy link
Author

hcoona commented Jul 3, 2024

Glade to learn the background! Should we file a proposal to NuGet to support this kind of hash?

@hcoona
Copy link
Author

hcoona commented Jul 3, 2024

I see a discussion about NuGet support single lock file may also helps to us. NuGet/Home#12409

@romaromaniv
Copy link

Hi @tomdegoede ,

It will be greatfull to get any updates about the feature!

  • what is feedback from development team?
  • what is priority?
  • potential blockers?

Our solution need the feature. We have 100+ projects.

Thanks in advance.

@tomdegoede
Copy link
Collaborator

@romaromaniv you can leverage the custom lockfile format. NuGet lock files are not compatible and only work per project.

@romaromaniv
Copy link

@tomdegoede thanks for the quick reply.

Could you please provide some more details - what means "the custom lockfile format"?

@tomdegoede
Copy link
Collaborator

This issue proposed the NuGet lockfile, but bazel_dotnet uses its own format. Please look at the examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants