-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow workspaces to reference themselves canonically #1033
Comments
Hi Justine, We decided this week to do be able to use the @kchodorow also work on a more principle ways to refer to external repository but that will take time. |
Is there an estimated timeline for this functionality becoming available in Bazel head? |
For reference, this sounds like it came out of the (fairly extensive) discussion in #975. |
|
This is now committed (6f15335). The options are:
|
This is a different issue that still doesn't seem to be fixed. This bug is about "@io_bazel_rules_closure//:something" working from the closure repository itself. It definitely does not work in a build_file attribute with current Bazel master. Once this is fixed, bazelbuild/rules_closure#9 will be easy to fix. |
On second thought, this doesn't actually block anything any more. Just using default-repository labels should work fine... However, it would be still nice if referring to the main repository by name worked for consistency. |
This is a blocking issue for the Closure Rules.
If I say:
Then I should be able to say within my workspace:
Which makes the codebase more copy/pasteable. But most importantly, I need to be able to say:
Because otherwise the bzl rule will have no way to reference its own tooling. This is because a bzl rule exists in the namespace to which it's loaded. Without the ability to specify a fully canonical name, the rule will only work from other repositories. But if I run
bazel test ...
within the Closure rules repository, it will not be able to test itself.CC: @damienmg
The text was updated successfully, but these errors were encountered: