Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean required after workaround to missing build file #1076

Closed
wolfgangmeyers opened this issue Mar 23, 2016 · 3 comments
Closed

clean required after workaround to missing build file #1076

wolfgangmeyers opened this issue Mar 23, 2016 · 3 comments
Labels
P2 We'll consider working on this in future. (Assignee optional) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug

Comments

@wolfgangmeyers
Copy link

As a follow up to #1075

In order to work around the problem, I can copy closure/library/closure_library.BUILD into my project. However this doesn't seem to take effect until bazel clean is run.

Steps to reproduce:

  1. unzip the project code from https://github.com/bazelbuild/bazel/files/186571/missing_closure_library.zip
  2. run bazel build //:main
  3. Copy the build file from rules_closure (https://github.com/bazelbuild/rules_closure/blob/master/closure/library/closure_library.BUILD) to closure/library
  4. run bazel build //:main again. This build should fail with the same error message.
  5. run bazel clean
  6. run bazel build //:main a third time. This build should succeed.
@kchodorow
Copy link
Contributor

Good find, we're not invalidating the BUILD file symlink.

@kchodorow kchodorow added External repositories P2 We'll consider working on this in future. (Assignee optional) labels Mar 23, 2016
@kchodorow kchodorow added this to the 0.6 milestone Jun 15, 2016
@dslomov dslomov added P1 I'll work on this now. (Assignee required) external-repos-triaged and removed P2 We'll consider working on this in future. (Assignee optional) labels Jan 11, 2018
@dslomov dslomov added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. P2 We'll consider working on this in future. (Assignee optional) and removed category: extensibility > external repositories P1 I'll work on this now. (Assignee required) labels Mar 21, 2019
@aehlig aehlig removed their assignment Feb 1, 2020
@meisterT meisterT removed this from the 0.6 milestone May 12, 2020
@meisterT
Copy link
Member

The example doesn't work with current Bazel anymore. Is this still an issue?

@philwo philwo added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jun 15, 2020
@philwo philwo removed the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Nov 29, 2021
@sgowroji
Copy link
Member

Hi there! We're doing a clean up of old issues and will be closing this one. Please reopen if you’d like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We'll consider working on this in future. (Assignee optional) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug
Projects
None yet
Development

No branches or pull requests

8 participants