-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bazel 7.0.2 build with --noenable_bzlmod
still produce MODULE.bazel file
#22994
Comments
Hmm, I'm not able to reproduce this
Note that we are also turning WORKSPACE off in Bazel 8, and plan to remove WORKSPACE in Bazel 9. See #23023 |
@meteorcloudy thank you for taking a look!
Thanks for the head up about dumping WORKSPAKCE. We will put it in our plan. |
@Wyverald Is there any possibility that the ModuleFileFunction.java gets triggered when --enable_bzlmod is off? |
Not that I know of. I just checked the code paths again, and it does look like we only ever eval |
@jacobmou Is it possible in some cases the bazelrc wasn't applied, for example, by passing |
We were suspecting the same thing. the so far seems like it's not causing any issue to our builds. I will try find a way to reproduce it, but if we can prove that's benign, we can just add it to .gitignore until we enable bzlmod. I will update here if we have new findings. Thanks for looking into this! |
Description of the bug:
We adopted bazel 7.0.2 in our code repo and disable bzl_mod in the root bazelrc file like
However, we are getting many user reports mention their builds still produce
MODULE.bazel
and/orMODULE.bazel.lock
files sporadically. We have not find a way to reproduce the issue yet.Which category does this issue belong to?
Core
What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
No response
Which operating system are you running Bazel on?
Ubuntu 22.04
What is the output of
bazel info release
?release 7.0.2-2-g4d9c49e5a4-aurora
If
bazel info release
returnsdevelopment version
or(@non-git)
, tell us how you built Bazel.we backported fix in 52adf0b.
What's the output of
git remote get-url origin; git rev-parse HEAD
?No response
If this is a regression, please try to identify the Bazel commit where the bug was introduced with bazelisk --bisect.
No response
Have you found anything relevant by searching the web?
No response
Any other information, logs, or outputs that you want to share?
No response
The text was updated successfully, but these errors were encountered: