The csharp_repositories functions reference to dotnet/nunit.BUILD doesn't work

[zaphar]

It works if you use it inside this repositories workspace but if you include this repository in a different workspace it can't find the build file. It looks for it in the current workspace instead.

/private/var/tmp/_bazel_jwall/a4f05aced329c5d1ca55a18062777a02/external/io_bazel_rules_dotnet/bazel-bazel_rules_dotnet/examples/example_test/BUILD:3:1: every rule of type csharp_nunit_test implicitly depends upon the target '@nunit//:nunit_exe_libs', but this target could not be found because of: no such package '@nunit//': In new_http_archive rule //external:nunit the 'build_file' attribute does not specify an existing file (/Users/jwall/Downloads/csharp_tests/dotnet/nunit.BUILD does not exist).

[kchodorow]

This is a known issue which has a fix at head (see bazelbuild/bazel#855). The csharp rules should be updated to refer to nunit.BUILD by label, btu if you're using an older version of Bazel, you'll need to just copy the nunit.BUILD file to your current repository.

[zaphar]

Okay so I just tried using a fully qualified label with head bazel and I still get an error:

/private/var/tmp/_bazel_jwall/a4f05aced329c5d1ca55a18062777a02/external/io_bazel_rules_dotnet/examples/example_test/BUILD:3:1: every rule of type csharp_nunit_test implicitly depends upon the target '@nunit//:nunit_framework', but this target could not be found because of: no such package '@nunit//': Unable to load package for @io_bazel_rules_dotnet//dotnet/nunit.BUILD: not found.

Am I just doing this wrong or is the fix not in github yet?

[zaphar]

never mind. found the error.

[zaphar]

@davidzchen Looks like it has to be a fully qualified name to work. so //dotnet:nunit.BUILD won't always work but @io_bazel_rules_dotnet//dotnet:nunit.BUILD will.

[davidzchen]

The problem with fully-qualifying the label that way is that it would only work if there is an external repository called io_bazel_rules_dotnet, in which chase running the examples from within the rules_dotnet repository would not work.

IIUC, this recent change by @kchodorow should fix this issue so that referring to //dotnet:nunit.BUILD from csharp.bzl in rules_dotnet will resolve to the //dotnet:nunit.BUILD within rules_dotnet.

@zaphar, which version of Bazel are you running? Can you try running Bazel at HEAD and see if this works for you?

[zaphar]

To verify I just git pulled and rebuilt bazel from head and then tested again. I still get this error:

/private/var/tmp/_bazel_jwall/a4f05aced329c5d1ca55a18062777a02/external/io_bazel_rules_dotnet/examples/example_test/BUILD:3:1: every rule of type csharp_nunit_test implicitly depends upon the target '@nunit//:nunit_framework', but this target could not be found because of: no such package '@nunit//': Unable to load package for //dotnet:nunit.BUILD: not found.

I can get this consistently by copying the examples directory from the rules_dotnet repo to a different directory and importing the rules_dotnet workspace as a local repo then trying to run the //examples/example_test:MyTest test from there.

[zaphar]

My bazel is on revision: e25642a2bcb68d553fe56b0c3d6262544b15a870

[zaphar]

Hrmmm So after looking at the advice given to the Closure rules I think the fix is to do str(Label("//dotnet:nunit.BUILD")) instead of just "//dotnet:nunit.BUILD" Which is a little janky but works.