go_test: fix filtering of _cgo files in external archives #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, new files that were generated by cgo (those prefixed with _cgo, like _cgo_gotypes.go, not those ending with .cgo1.go) were compiled automatically without any filter for tags or package names. This broke combined tests with an external component that depended on library that contained cgo: the _cgo files would get compiled into the external archive since the compile builder did not filter them by package name. This caused errors when package names in source files did not match. With this change, in analysis, we treat cgo files like regular source files. In the compile builder, we filter them normally, except we don't check build constraints (these files would always be excluded, since they start with '_').
ianthehat
approved these changes
Apr 3, 2018
jayconrod
added a commit
that referenced
this pull request
Apr 4, 2018
Previously, new files that were generated by cgo (those prefixed with _cgo, like _cgo_gotypes.go, not those ending with .cgo1.go) were compiled automatically without any filter for tags or package names. This broke combined tests with an external component that depended on library that contained cgo: the _cgo files would get compiled into the external archive since the compile builder did not filter them by package name. This caused errors when package names in source files did not match. With this change, in analysis, we treat cgo files like regular source files. In the compile builder, we filter them normally, except we don't check build constraints (these files would always be excluded, since they start with '_').
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, new files that were generated by cgo (those prefixed with
_cgo, like _cgo_gotypes.go, not those ending with .cgo1.go) were
compiled automatically without any filter for tags or package
names. This broke combined tests with an external component that
depended on library that contained cgo: the _cgo files would get
compiled into the external archive since the compile builder did not
filter them by package name. This caused errors when package names in
source files did not match.
With this change, in analysis, we treat cgo files like regular source
files. In the compile builder, we filter them normally, except we
don't check build constraints (these files would always be excluded,
since they start with '_').