Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command line copts/cxxopts to Cgo compile flags #3126

Merged
merged 1 commit into from
Apr 25, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions go/private/context.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,7 @@ def _cgo_context_data_impl(ctx):
feature_configuration = feature_configuration,
action_name = C_COMPILE_ACTION_NAME,
variables = c_compile_variables,
),
) + ctx.fragments.cpp.copts + ctx.fragments.cpp.conlyopts,
_COMPILER_OPTIONS_BLACKLIST,
)
env.update(cc_common.get_environment_variables(
Expand All @@ -596,7 +596,7 @@ def _cgo_context_data_impl(ctx):
feature_configuration = feature_configuration,
action_name = CPP_COMPILE_ACTION_NAME,
variables = cxx_compile_variables,
),
) + ctx.fragments.cpp.copts + ctx.fragments.cpp.cxxopts,
_COMPILER_OPTIONS_BLACKLIST,
)
env.update(cc_common.get_environment_variables(
Expand Down