Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go_path: support go:embed of generated files #3285

Merged
merged 2 commits into from
Nov 24, 2022
Merged

go_path: support go:embed of generated files #3285

merged 2 commits into from
Nov 24, 2022

Commits on Nov 24, 2022

  1. go_path: support go:embed of generated files 

    When embedded files are generated, relativize fails because the file
path starts with the output directory. Without the change in path.bzl,
the test case fails as follows:

Error in fail: Path 'bazel-out/darwin-fastbuild/bin/tests/core/go_path/pkg/lib/renamed_embedded_src.txt'
is not beneath 'tests/core/go_path/pkg/lib'
    @S-Chan @fmeum
    S-Chan authored and fmeum committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    075b50d View commit details
    Browse the repository at this point in the history

  2. Update tests/core/go_path/cmd/bin/BUILD.bazel

    @fmeum
    fmeum committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    4199e8f View commit details
    Browse the repository at this point in the history