Fix use of //go with Bzlmod by removing dependency on @org_golang_x_sys

[bricedp]

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

Running bazel run //go (or bazel run @rules_go//go from another module) fails when using Bzlmod because the @org_golang_x_sys repository is not visible. Without Bzlmod, the repository is loaded through a WORKSPACE dependency and the error does not happen.

Related to these recent changes:

• Make the toolchain's go binary available as a target #3429
• Make //go usable in scripts run with bazel run #3474

Two-step minimal reproduction from root of this repo:

1. touch WORKSPACE.bzlmod
2. bazel run --enable_bzlmod //go

Here's the error that produces:

$ bazel run --enable_bzlmod //go
DEBUG: [email protected]/MODULE.bazel:7:6: WARNING: The bazel_gazelle Bazel module is still highly experimental and subject to change at any time. Only use it to try out bzlmod for now.
WARNING: For repository 'com_google_protobuf', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
ERROR: /tmp/rules_go/go/tools/go_bin_runner/BUILD.bazel:11:11: no such package '@[unknown repo 'org_golang_x_sys' requested from @]//unix': The repository '@[unknown repo 'org_golang_x_sys' requested from @]' could not be resolved: No repository visible as '@org_golang_x_sys' from main repository and referenced by '//go/tools/go_bin_runner:go_bin_runner_lib'
ERROR: Analysis of target '//go:go' failed; build aborted: 
INFO: Elapsed time: 3.043s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (45 packages loaded, 865 targets configured)
    currently loading: go/platform
ERROR: Build failed. Not running target

Here's the point in the BUILD file where this repository is being referenced:

rules_go/go/tools/go_bin_runner/BUILD.bazel

Line 25 in e558f56

"//conditions:default": ["@org_golang_x_sys//unix"],

Which issues(s) does this PR fix?

None

Other notes for review

[fmeum]

Thanks for the report and fix.

This dependency is indeed missing. In fact, even with your fix, we only pick it up indirectly from Gazelle as it's not declared via go_deps in rules_go's MODULE.bazel file.

Given that golang.org/x/sys isn't promising backwards compatibility, I think that we may just be better of getting rid of this direct dependency - it isn't even clear that it is better than the pure Go alternative.

@bricedp Could you try deleting process_unix.go and the references to it and golang.org/x/sys in

rules_go/go/tools/go_bin_runner/BUILD.bazel

Line 17 in e558f56

"//conditions:default": ["process_unix.go"],

? If that works, I think I would prefer that fix.

[bricedp]

Thanks @fmeum, I agree that's much cleaner. I've removed process_unix.go and updated the BUILD file — I'm able to run //go without issue.

If ever needed for the future, I think the @org_golang_x_sys I had added was being brought in by the explicit call to go_rules_dependencies, which appears to be a newer version than the indirect dependency in go.mod.

rules_go/go/private/extensions.bzl

Line 157 in e558f56

go_rules_dependencies(force = True)

rules_go/go/private/repositories.bzl

Lines 86 to 101 in e558f56

	wrapper(
	http_archive,
	name = "org_golang_x_sys",
	# v0.6.0, latest as of 2023-03-27
	urls = [
	"https://mirror.bazel.build/github.com/golang/sys/archive/refs/tags/v0.6.0.zip",
	"https://github.com/golang/sys/archive/refs/tags/v0.6.0.zip",
	],
	sha256 = "7f2399398b2eb4f1f495cc754d6353566e0ad934ee0eb46505e55162e0def56d",
	strip_prefix = "sys-0.6.0",
	patches = [
	# releaser:patch-cmd gazelle -repo_root . -go_prefix golang.org/x/sys -go_naming_convention import_alias
	Label("//third_party:org_golang_x_sys-gazelle.patch"),
	],
	patch_args = ["-p1"],
	)

[fmeum]

Looks good, thanks!

I will try to add a simple sh_test to tests/bcr that runs go version so that we don't regress this functionality.

[fmeum]

@bricedp Sorry, I wanted to add a commit to your branch, but unfortunately pushed the master branch of rules_go rather than my checkout of your fork to it, thus closing the PR. I can no longer push to it to clean up the mess. Could you restore the commits from https://github.com/fmeum/rules_go/tree/bricedp/master and open a new PR?

[bricedp]

Thanks @fmeum for the tests, opened #3512 with our changes.