Pass -trimpath to cgo in stdlib action
#3569
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `go install` invokes `cgo`, we need to pass `-trimpath`, but there doesn't seem to be a way to influence the command line. Instead, use `filterbuildid` to inject the argument. This resolves one source of non-hermeticity when building the stdlib with the hermetic C++ toolchain, but another one remains.
|
There is an interesting failure in |
|
Seems hard to get right: golang/go#27751 Edit: Also related to golang/go#51955. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
go installinvokescgo, we need to pass-trimpath, but there doesn't seem to be a way to influence the command line. Instead, usefilterbuildidto inject the argument.This resolves one source of non-hermeticity when building the stdlib with the hermetic C++ toolchain, but another one remains.