Remove deprecated gogo proto compiler #3767
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mering
force-pushed
the
remove-deprecated-gogo
branch
from
f1be6ac
to
a9ee0cb
Compare
|
@linzhp Do you see any reason to keep these around? |
|
No objection removing the validator, but can we please keep gogo for a bit longer. Uber still needs more time moving away from it. |
mering
force-pushed
the
remove-deprecated-gogo
branch
from
a9ee0cb
to
d715044
Compare
mering
force-pushed
the
remove-deprecated-gogo
branch
3 times, most recently
from
4fc44c3
to
637508e
Compare
mering
force-pushed
the
remove-deprecated-gogo
branch
from
637508e
to
52d9582
Compare
|
We need 2-3 years to migrate away from gogo. However, we only use "gogo", "gogofast" and "gogoslick" variants. So you can remove other variants if that helps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Cleanup
What does this PR do? Why is it needed?
Cleanup deprecated gogo proto compiler in order to make changes to rules_go easier.
Which issues(s) does this PR fix?
Other notes for review