-
-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Stardoc to 0.6.2 . #3966
base: master
Are you sure you want to change the base?
Conversation
This is in turn to make rules_go work with `--experimental_sibling_repository_layout`. It required some re-shuffling of the stanzas in the WORKSPACE file for rules_proto, Stardoc and rules_go itself. I did not investigate deeper given that the plan of record is to migrate to bzlmod.
Argh. The CI failure seems to be reproducible by
My guess: the upgrade to Stardoc also requires an upgrade of |
Could you also add the flag here: Without this, we won't have good CI coverage as most tests are integration tests. The error about invalid escapes is related to rules_go using custom templates. I could look into getting rid of them if that simplifies the update. |
I haven't looked at the error about invalid escapes, since, well, fixing the other one seems to be complicated enough so I'll go with the generic uninformed opinion that it'd be great help; otherwise I don't know what exactly in the Stardoc update broke this; I wanted to look at it after I figure out the proto toolchain issue. |
The Stardoc issue is fixed in bazelbuild/stardoc#237 (I tested the two both). I also managed to reproduce the escaping issue without requiring Windows by the sneaky method of calling
|
Okay, I can look into it after the stardoc fix has been released, together with the general migration required at that point. |
Well, I was hoping it'd be a simple thing but turns out, not so; this is my first encounter with the magnificent Velocity Template Language and all my naive attempts to circumvent the backspace limitation failed. |
I would be in favor of getting rid of the custom templates in favor of whatever stardoc ships by default. If that gets rid of the escaping issue, that's a plus. |
That is beyond my mandate here, I'm afraid; I was trying to do some adversarial programming to find a way to get a backslash into that string literal, to no avail, so the best I could do is to add some hackish method to Ain't nice, but it would work. |
This is in turn to make rules_go work with
--experimental_sibling_repository_layout
or at least makesbazel build --experimental_sibling_repository_layout //docs:docs_go_extras_extras-docgen
pass.It required some re-shuffling of the stanzas in the WORKSPACE file for rules_proto, Stardoc and rules_go itself. I did not investigate deeper given that the plan of record is to migrate to bzlmod.
What type of PR is this?
What does this PR do? Why is it needed?
Makes
rules_go
work with--experimental_sibling_repository_layout
. Or at least fixes one problem.Which issues(s) does this PR fix?
Fixes #3947
Other notes for review