Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Downloaded xxx" and "Compiling xxx" log spam #2822

Open
lalten opened this issue Aug 30, 2024 · 7 comments
Open

"Downloaded xxx" and "Compiling xxx" log spam #2822

lalten opened this issue Aug 30, 2024 · 7 comments
Labels

Comments

@lalten
Copy link

lalten commented Aug 30, 2024

I'm getting over 400 lines of "Downloaded xxx" and "Compiling xxx" before "Finished release profile [optimized] target(s) in 51.94s". Is there a way to reduce that log spam?

I know Cargo has a --quiet option but it's not immediately obvious to me where in rules_rust that would have to be added. Any pointers?

@UebelAndre
Copy link
Collaborator

Where do you see this? Can you post some logs?

@lalten
Copy link
Author

lalten commented Sep 3, 2024

Here is a bazel coverage invocation, but I've also seen it happen on bazel mod deps --lockfile_mode=update and other calls. It's likely related to having a fresh cache on a new CI runner.

imageimage

@UebelAndre
Copy link
Collaborator

What version of rules_rust are you using?

@lalten
Copy link
Author

lalten commented Sep 4, 2024

Currently on 0.46.0 (with some minor patches like adding requires-network execution_requirements for a custom rustc with QNX support and adding custom target triples)

@lalten
Copy link
Author

lalten commented Sep 8, 2024

I just observed this in https://github.com/lalten/appimage-runtime-rs/actions/runs/10760111232/job/29837618758.
rules_rust is at current main without any patches in that branch.

@UebelAndre
Copy link
Collaborator

Is bzlmod not using the release artifacts? On main there are no pre-built cargo-bazel binaries available so in order to generate 3rdparty dependencies with crate_universe the binary needs to be bootstrapped. If you're using releases or build your own cargo_bazel attribute (though I'm not sure if this is exposed to bzlmod). I'd be happy to review pull requests that made configuring this clearer and easier 😄

@lalten
Copy link
Author

lalten commented Nov 5, 2024

It looks like the issue was indeed that the bazel_dep() pointed at specific commits rather than releases!
Maybe it would make sense to print a message informing the user about what's happening?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants