Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix module path #335

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix module path #335

wants to merge 1 commit into from

Conversation

sxh519
Copy link

@sxh519 sxh519 commented Aug 17, 2020

fix #334

@sxh519 sxh519 requested a review from a team as a code owner August 17, 2020 03:07
@grumbach grumbach self-requested a review August 19, 2020 14:18
grumbach
grumbach requested changes Aug 19, 2020
View reviewed changes
Copy link
Member

@grumbach grumbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this PR! But could you please adapt the tests for the CI checks before we Merge this? Thanks!

daemon/common_test.go:32:3: cannot use &mockDriver literal (type *mockDriver) as type Driver in return argument:
	*mockDriver does not implement Driver (wrong type for State method)
		have State() (*"github.com/bblfsh/bblfshd/daemon/protocol".DriverInstanceState, error)
		want State() (*"github.com/bblfsh/bblfshd/v2/daemon/protocol".DriverInstanceState, error)
daemon/pool_test.go:127:6: impossible type assertion:
	*mockDriver does not implement Driver (wrong type for State method)
		have State() (*"github.com/bblfsh/bblfshd/daemon/protocol".DriverInstanceState, error)
		want State() (*"github.com/bblfsh/bblfshd/v2/daemon/protocol".DriverInstanceState, error)

@kuba--
Copy link
Member

kuba-- commented Jul 4, 2023

@sxh519 - are you still working on this?
Can you fix tests ☝🏻 ?

@david972 david972 self-requested a review July 5, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grumbach grumbach grumbach requested changes

@kuba-- kuba-- kuba-- approved these changes

@david972 david972 Awaiting requested review from david972

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@sxh519 @kuba-- @grumbach @trimming-code