diff --git a/README.md b/README.md index 1bd2ba64..48c2ca73 100644 --- a/README.md +++ b/README.md @@ -21,6 +21,11 @@ Real time console spec reporter for jasmine behavior-driven development testing success: 'green', failure: 'red', skipped: 'cyan' + }, + prefixes: { + success: '✓ ', + failure: '✗ ', + skipped: '- ' } } diff --git a/example/example-spec.coffee b/example/example-spec.coffee index 7eb9f2c7..b6591e61 100644 --- a/example/example-spec.coffee +++ b/example/example-spec.coffee @@ -11,6 +11,11 @@ jasmine.getEnv().addReporter(new jasmine.SpecReporter({ success: 'green', failure: 'red', skipped: 'cyan' + }, + prefixes: { + success: '✓ ', + failure: '✗ ', + skipped: '- ' } })) diff --git a/package.json b/package.json index afc4d759..acd4190b 100644 --- a/package.json +++ b/package.json @@ -4,8 +4,8 @@ "description": "Spec reporter for jasmine behavior-driven development framework", "main": "src/jasmine-spec-reporter.js", "scripts": { - "test": "./node_modules/jasmine-node/bin/jasmine-node --coffee --noStack spec", - "example": "./node_modules/jasmine-node/bin/jasmine-node --coffee example" + "test": "node node_modules/jasmine-node/bin/jasmine-node --coffee --noStack spec", + "example": "node node_modules/jasmine-node/bin/jasmine-node --coffee example" }, "repository": { "type": "git", diff --git a/spec/jasmine-spec-reporter.spec.coffee b/spec/jasmine-spec-reporter.spec.coffee index b6aaa6dd..d244810f 100644 --- a/spec/jasmine-spec-reporter.spec.coffee +++ b/spec/jasmine-spec-reporter.spec.coffee @@ -171,6 +171,7 @@ describe 'spec reporter', -> '' ] + it 'should report skipped whith success', -> expect(new Test(@reporter,-> @describe 'suite', -> @@ -323,6 +324,7 @@ describe 'spec reporter', -> @failed() ).outputs).not.contains /failed suite/ + it 'should display not fully failed suite', -> outputs = new Test(@reporter,-> @describe 'failed suite', -> @@ -372,6 +374,7 @@ describe 'spec reporter', -> ).outputs) .contains /✗ failed spec \({time}\)/ + describe 'with prefixes set to empty strings', -> beforeEach -> @reporter = new jasmine.SpecReporter({displaySkippedSpec: true, prefixes: {success: '', failure: '', skipped: ''}}) @@ -394,6 +397,7 @@ describe 'spec reporter', -> ).outputs) .not.contains /✗/ + it 'should report skipped', -> expect(new Test(@reporter,-> @describe 'suite', -> @@ -401,6 +405,7 @@ describe 'spec reporter', -> ).outputs) .not.contains /-/ + describe 'with prefixes set to valid strings', -> beforeEach -> @reporter = new jasmine.SpecReporter({displaySkippedSpec: true, prefixes: {success: 'Pass ', failure: 'Fail ', skipped: 'Skip '}}) @@ -423,6 +428,7 @@ describe 'spec reporter', -> ).outputs) .not.contains /✗/ + it 'should report skipped', -> expect(new Test(@reporter,-> @describe 'suite', -> @@ -430,34 +436,6 @@ describe 'spec reporter', -> ).outputs) .not.contains /-/ - describe 'with prefixes not set', -> - beforeEach -> - @reporter = new jasmine.SpecReporter({displaySkippedSpec: true, prefixes: {} }) - - describe 'when spec', -> - it 'should report success', -> - expect(new Test(@reporter,-> - @describe 'suite', -> - @it 'successful spec', -> - @passed() - ).outputs) - .contains /✓/ - - - it 'should report failure', -> - expect(new Test(@reporter,-> - @describe 'suite', -> - @it 'failed spec', -> - @failed() - ).outputs) - .contains /✗/ - - it 'should report skipped', -> - expect(new Test(@reporter,-> - @describe 'suite', -> - @xit 'skipped spec', -> - ).outputs) - .contains /-/ describe 'with jasmine callback hack', -> beforeEach -> diff --git a/src/jasmine-spec-reporter.js b/src/jasmine-spec-reporter.js index f7800d0d..6c242383 100644 --- a/src/jasmine-spec-reporter.js +++ b/src/jasmine-spec-reporter.js @@ -123,7 +123,7 @@ SpecDisplay.prototype = { this.ensureSuiteDisplayed(spec.suite); var result = spec.results().description; var duration = this.displaySpecDuration ? ' (' + spec.duration + ')' : ''; - this.log(this.prefixes.success + result.success + duration) + this.log(this.prefixes.success.success + result.success + duration) } }, @@ -133,7 +133,7 @@ SpecDisplay.prototype = { this.ensureSuiteDisplayed(spec.suite); var result = spec.results().description; var duration = this.displaySpecDuration ? ' (' + spec.duration + ')' : ''; - this.log(this.prefixes.failure + result.failure + duration); + this.log(this.prefixes.failure.failure + result.failure + duration); this.displayErrorMessages(spec); } }, @@ -142,7 +142,7 @@ SpecDisplay.prototype = { if (this.displaySkippedSpec) { this.ensureSuiteDisplayed(spec.suite); var result = spec.results().description; - this.log(this.prefixes.skipped + result.skipped) + this.log(this.prefixes.skipped.skipped + result.skipped) } },