Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes error when the stacktrace is undefined #22

Closed
wants to merge 1 commit into from

Conversation

0xR
Copy link
Contributor

@0xR 0xR commented Jan 7, 2015

When a protractor test has a timeout the stacktrace value is not defined. This causes the following error output:

    some page
      ✗ should do something (0.039 secs)
        - timeout: timed out after 10 msec waiting for spec to complete

/home/0xR/workspace/node_modules/jasmine-spec-reporter/src/spec-display.js:110
    var lines = traces.split('\n');
                       ^
TypeError: Cannot call method 'split' of undefined
    at Object.SpecDisplay.filterStackTraces (/home/0xR/workspace/node_modules/jasmine-spec-reporter/src/spec-display.js:110:24)
    at Object.SpecDisplay.displayErrorMessages (/home/0xR/workspace/node_modules/jasmine-spec-reporter/src/spec-display.js:102:25)
    at Object.SpecDisplay.failed (/home/0xR/workspace/node_modules/jasmine-spec-reporter/src/spec-display.js:80:12)
    at Object.SpecReporter.reportSpecResults (/home/0xR/workspace/node_modules/jasmine-spec-reporter/src/jasmine-spec-reporter.js:85:20)

This change solves that issue.

bcaudan pushed a commit that referenced this pull request Jan 8, 2015
@bcaudan
Copy link
Owner

bcaudan commented Jan 8, 2015

Nice catch, thanks!
It is available in 1.1.1.

@bcaudan bcaudan closed this Jan 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants