-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'SpecReporter' is not assignable to type 'Reporter | CustomReporter' #588
Comments
As a workaround you can do import CustomReporter = jasmine.CustomReporter;
jasmine.getEnv().addReporter((new SpecReporter() as unknown) as CustomReporter); |
Thanks! I just added a |
Indeed, it seems to have been detected by dependabot as well #585 I'll look into it, thanks for the heads up |
@bcaudan any update? I forked and looked at it, but it seems there's quite some changes involved |
I have started to look into it but I have to look deeper into the spec duration from jasmine to see if there is still a need for jasmine-spec-reporter to compute it as well. |
Covid-19 helping open source development 😁 |
A fix is available in jasmine-spec-reporter@7.0.0 |
This saved me after days of debugging. Thank you @SetupCoding |
Issue guidelines
Bug report
Check with "x":
Current behavior
I'm encountering a type error when configuring the spec reporter, probably related to the latest
@types/jasmine
package:Expected behavior
No type error, assignment works as expected.
Minimal reproduction of the problem with instructions
Package versions:
@types/jasmine
: 3.6.6jasmine
: 3.6.4jasmine-spec-reporter
: 6.0.0Possible fix
Change the typing of
duration
tonumber | null
here:jasmine-spec-reporter/src/spec-reporter.ts
Lines 20 to 22 in 8d7bd5f
The text was updated successfully, but these errors were encountered: