-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZEVA - Limit Credit Applications to 2,000 VIN #1451
Comments
Hey team! Please add your planning poker estimate with Zenhub @AlexZorkin @emi-hi @tim738745 @vibhiquartech |
@airinggov Currently, the way this works is if the spreadsheet contains more than 50,000 rows, only the first 50,000 will be read, and the rest will be silently ignored. So by changing the upper bound to 2000, only the first 2000 will be read, and any additional records will be ignored (there are no error messages for the user). |
@tim738745 I wonder if we can also limit the amount of rows in the Excel template. I think you can do this in Excel but not sure it is possible in the template that we generate. |
@tim738745 there is error checking when the Excel file is uploaded. Perhaps we can add a line count check and return a message; Excel file exceeds 2,000 lines |
@airinggov yes, you're right; I have added the error checking/message |
@tim738745 can you remove the text "Please download the template again and try again." from the error message? |
@airinggov sure! |
Title: Limit Credit Applications to maximum 2,000 VIN
Description: Large credit applications are very hard to manage for IDIR users. Presently there is an upper limit of 50,000 VIN specified in the first tab (Instructions) of the Excel download template, this is too large. Change this value to 2,000.
Also the heading on the Credit Application page as per the wireframe.
Upload ZEV Sales Information (Maximum 2,000 VIN per application)
I'm not sure if the Excel file has a restriction of 2,000 rows or if the upload function gives an error message if they do include more than 50,000 lines. This may require some investigation as to how this is actually handled.
Wireframe:
https://preview.uxpin.com/4946124c44da522837a3b54ccb7b5243fa384039#/pages/134764132?mode=fm
Purpose and benefit to user:
Acceptance Criteria:
Development Checklist:
Notes:
The text was updated successfully, but these errors were encountered: