You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
master branch must ALWAYS have the latest stable version and MUST be git tagged with a release version number
2.2-stable branch, while it's the latest stable version, MUST mirror master branch completely
the last commit in branch that retains the latest stable code (master as a main branch in gitflow model) MUST have the git tag of the latest stable release version number.
if the 2.2-stable branch is not intended to be used as the latest stable code (according to the gitflow model), but as a supporting branch one step before the code get into the latest stable branch (master), rename it in order to not confusing contributors and users as well. Maybe just 2.2 (as https://github.com/symfony/symfony/tree/2.5) or CI-2.2 (as https://github.com/php/php-src/tree/PHP-5.6).
Thanks in advance for taking a look on this!
The text was updated successfully, but these errors were encountered:
Hello,
I just like to suggest reviewing the application
gitflow
branching model because, IMHO, it's not being applied appropriately in this repo nowadays (mainly because oftags
,master branch
and2-2-stable branch
) even with https://github.com/EllisLab/CodeIgniter/blob/develop/contributing.md#branching pointing it should be.In time: https://danielkummer.github.io/git-flow-cheatsheet/index.html or the original blog post http://nvie.com/posts/a-successful-git-branching-model/.
Points to be reviewed, again, IMHO:
master branch
must ALWAYS have the latest stable version and MUST begit tagged
with a release version number2.2-stable branch
, while it's the latest stable version, MUST mirrormaster branch
completelymaster
as a main branch in gitflow model) MUST have thegit tag
of the latest stable release version number.Suggestion to solve the points right now:
2.2-stable
BUMP VERSION to 2.2.1 release containing the bug fix CI 2.2.0 - pdo: rowCount non-object error because $this->result_id is not an object #30952.2-stable
intomaster
master
, git tag 2.2.1 and release it (http://ellislab.com/codeigniter)2.2-stable branch
is not intended to be used as the latest stable code (according to the gitflow model), but as a supporting branchone step
before the code get into the latest stable branch (master
), rename it in order to not confusing contributors and users as well. Maybe just2.2
(as https://github.com/symfony/symfony/tree/2.5) or CI-2.2 (as https://github.com/php/php-src/tree/PHP-5.6).Thanks in advance for taking a look on this!
The text was updated successfully, but these errors were encountered: