Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure AsyncIdle #47

Open
heuristicus opened this issue Jun 30, 2023 · 0 comments
Open

Restructure AsyncIdle #47

heuristicus opened this issue Jun 30, 2023 · 0 comments

Comments

@heuristicus
Copy link
Collaborator

Currently AsyncIdle has a mixture of uses and does quite a few different things depending on the state of various flags.

I don't really know the best way to do this, but perhaps starting by splitting the function up into separate functions handling each of the commands makes sense.

The variables that are now in RobotState are set by its _start_query method. But I think some of these variables are probably not correctly tracking the actual state of the robot. Ideally this information would come from the SDK in some way but I'm not sure that's possible.

It also sends the stand command repeatedly if no command is running. I'm not sure this is really necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant