Skip to content
This repository has been archived by the owner on Dec 10, 2019. It is now read-only.

Save/Load selected mods #23

Merged
merged 8 commits into from
Apr 10, 2019
Merged

Save/Load selected mods #23

merged 8 commits into from
Apr 10, 2019

Conversation

Skattered
Copy link

Save selected mods to text file on install, read from file on load and add to defaultmods list to check boxes
addresses #16

@Skattered
Save/Load selected mods
dec398c 
Save selected mods to text file on install, read from file on load and add to defaultmods list to check boxes
@Benik3
Copy link

Benik3 commented Apr 10, 2019

Nice. What to save the txt file into folder like %AllUsersProfile%? So when you move the exe it will still work and you don't have to move the txt file...

@megalon
Check if "mods.txt" exists
dd7fb41
@megalon
Store ReleaseInfo name instead of ListItem name
1d0018e 
This way it doesn't store the `[REQUIRED]` or `[DEPENDENCY]` text in the mods text file
@Skattered
Copy link
Author

Nice. What to save the txt file into folder like %AllUsersProfile%? So when you move the exe it will still work and you don't have to move the txt file...

That's not a bad idea, I just didn't want to leave remnants behind somewhere hidden if someone deletes the mod installer, this way they can see the file in the same dir they started.

@megalon
Copy link
Member

megalon commented Apr 10, 2019

I made a couple of adjustments, and addressed a case where the mods.txt file didn't exist.
Now that I think about it, the theme settings are currently stored using Properties.Settings, which saves to C:\Users\username\AppData\Local\BeatSaberModManager\

It would make sense to store the selected mods list here as well.

@Benik3
Copy link

Benik3 commented Apr 10, 2019

Yes, that also make sense.

@megalon megalon added the enhancement New feature or request label Apr 10, 2019
@megalon megalon requested a review from Assistant April 10, 2019 22:45
Assistant
Assistant approved these changes Apr 10, 2019
View reviewed changes
Copy link
Collaborator

@Assistant Assistant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Assistant Assistant merged commit 727090c into bsmg:master Apr 10, 2019
@megalon megalon mentioned this pull request Apr 11, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Assistant Assistant Assistant approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Skattered @Benik3 @megalon @Assistant