This repository has been archived by the owner on Dec 10, 2019. It is now read-only.
Added BeatSaver OneClick installer #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added windows push notification
|
Tried it with ModelSaber, and it works great, however it saves the files with their names urlencoded. Would it be possible to decode that? |
|
I knew I forgot something, but as I see you already fixed it. Thanks for merging. Oh and two things, I found a small spelling mistake https://github.com/beat-saber-modding-group/BeatSaberModInstaller/blob/bdb8f95a9876a9a6dc787ab84bd12af1f0965065/BeatSaberModManager/Core/OneClickInstaller.cs#L158 Maybe you can squeeze it into your next commit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Do not merge yet, protocol discussions still open, issue: #21]
Basic oneclick downloading should work for songs, avatars, platforms and sabers.
When downloading a song, no new modinstaller window will open and the install will be done quietly in the background. However if one is already open a download start/success/error notification will appear in the status bar.
Windows UAC is a bit annoying since it pops up for each song install.
My solution suggestion based on some googling would be to remove the default privilege request from the manifest and instead check at startup whether the modinstaller should be loaded and restart with admin privileges (should not be noticable to the user). There are a few other weird techniques, however I'm open for discussion here. For now I haven't changed anything in this pr yet.