Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this extension still supports applying Allman style to CSS? #1353

Closed
gusbemacbe opened this issue Mar 2, 2018 · 10 comments
Closed

Does this extension still supports applying Allman style to CSS? #1353

gusbemacbe opened this issue Mar 2, 2018 · 10 comments

Comments

@gusbemacbe
Copy link

gusbemacbe commented Mar 2, 2018

Hello,

Referring to #1259. I would like to apply Allman style (expand) to CSS, I hate the KNK style. I applied it and it doesn't work. Observation: The indent size didn't work either.

Environment

OS verison: macOS 10.13.3
VSCode version: Insider 1.21.0

Settings

"beautify.options":
{
        "brace_style": "expand",
        "indent_size": 2,
        "css": 
        {
            "brace_style": "expand",
            "indent_size": 1
        },
}
@gusbemacbe gusbemacbe changed the title Does this extension supports applying Allman style to CSS? Does this extension still supports applying Allman style to CSS? Mar 2, 2018
@bitwiseman
Copy link
Member

This is not currently supported. I've added this to the backlog.

@proimage
Copy link

proimage commented Feb 5, 2019

Nearly a year... any news about this?

@gusbemacbe
Copy link
Author

I am waiting yet...

@bitwiseman
Copy link
Member

bitwiseman commented Feb 6, 2019

@proimage @gusbemacbe
As with so many features of the project, this is awaiting someone to take ownership of it and drive it to completion. Looking at it, it is probably something that someone could add with relative ease. You interested?

@gusbemacbe
Copy link
Author

Hi @bitwiseman !

I am ready to be a collaborator as I got graduated in computer science and received a diploma yesterday. But I am not totally advanced in JavaScript and in Nodejs. I am studying them in the moment. May I take?

@proimage
Copy link

proimage commented Feb 6, 2019

If I knew how to program, I might. Sorry!

@bitwiseman
Copy link
Member

@gusbemacbe
Go right ahead. You don't need to be advanced.
The change will be in this area: https://github.com/beautify-web/js-beautify/blob/master/js/src/css/beautifier.js#L286-L310

Come over to the project gitter channel if you want to chat.

@gusbemacbe
Copy link
Author

Better to fork and git-clone this repository and test it manually before to pull request. I have to run node run inside the git-cloned folder.

@gusbemacbe
Copy link
Author

It seems to give a small error.

@bitwiseman
Copy link
Member

bitwiseman commented Feb 7, 2019

@gusbemacbe
Yes, fork and git clone.
We use make to run build and test.
See https://github.com/beautify-web/js-beautify/blob/master/CONTRIBUTING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants