Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why put npm in dependencies? #2005

Closed
dongnaebi opened this issue Mar 29, 2022 · 5 comments · Fixed by #2006
Closed

Why put npm in dependencies? #2005

dongnaebi opened this issue Mar 29, 2022 · 5 comments · Fixed by #2006

Comments

@dongnaebi
Copy link

Description

npm in dependencies
https://github.com/beautify-web/js-beautify/blob/main/package.json#L56

Input

run any npm command

Expected Output

success

Actual Output

npm does not support Node.js v10.17.0
You should probably upgrade to a newer version of node as we
can't make any promises that npm will work with this version.
You can find the latest version at https://nodejs.org/
/data/jenkins/workspace/oa-pc-dev/node_modules/npm/lib/npm.js:32
#unloaded = false
^

SyntaxError: Invalid or unexpected token
at Module._compile (internal/modules/cjs/loader.js:723:23)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
at Module.load (internal/modules/cjs/loader.js:653:32)
at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
at Function.Module._load (internal/modules/cjs/loader.js:585:3)
at Module.require (internal/modules/cjs/loader.js:692:17)
at require (internal/modules/cjs/helpers.js:25:18)
at module.exports (/data/jenkins/workspace/oa-pc-dev/node_modules/npm/lib/cli.js:22:15)
at Object. (/data/jenkins/workspace/oa-pc-dev/node_modules/npm/bin/npm-cli.js:2:25)
at Module._compile (internal/modules/cjs/loader.js:778:30)

Steps to Reproduce

any node 10.x can reproduce

npm list npm

Environment

OS: all system

Settings

@bitwiseman
Copy link
Member

Probably just a mistake.

@lyonbot
Copy link

lyonbot commented Mar 29, 2022

Can you remove that from dependency list? It's blocking our CI system.

@attitudeuser
Copy link

I also encountered this mistake

@bitwiseman
Copy link
Member

PRs welcome, folks.

@lyonbot lyonbot mentioned this issue Mar 29, 2022
6 tasks
@bitwiseman bitwiseman added this to the v1.14.x milestone Mar 29, 2022
@bitwiseman
Copy link
Member

Fixed and release as v1.14.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants