Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python port of HTML-beautifier - how to approach ? #2292

Open
jkmnt opened this issue Jul 5, 2024 · 2 comments
Open

Python port of HTML-beautifier - how to approach ? #2292

jkmnt opened this issue Jul 5, 2024 · 2 comments

Comments

@jkmnt
Copy link
Contributor

jkmnt commented Jul 5, 2024

I (mostly) ported the html formatter to python:
https://github.com/jkmnt/js-beautify-py-html/tree/pyhtml/python/jsbeautifier/html

It passes the smoke test :-) The missing parts are calls to the embedded js/css formatters and cli.

Any chances of it to be eventually merged ?
If yes, I would like to have need some guidance on cli part (now the js and css beautifiers are separate packages in Python) and running HTML tests.
If no, I'll just finalize and use my own fork.

I added a some typehints to the core to simplify the porting. Maybe merging these is a good first step, since there are no runtime changes.

@jkmnt
Copy link
Contributor Author

jkmnt commented Jul 5, 2024

I guessed the tests are must in any case. It passes all the tests now :)

@bitwiseman
Copy link
Member

If the port is relatively close and can continue to be maintained similar to the way the js beautifier is, I'm open to merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants