Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.7.0 fail to install through pip #1250

Closed
sladedals opened this issue Sep 18, 2017 · 3 comments
Closed

Version 1.7.0 fail to install through pip #1250

sladedals opened this issue Sep 18, 2017 · 3 comments
Milestone

Comments

@sladedals
Copy link

The newly version 1.7.0 released a few days ago doesn't want to install well through pip.

Here what I obtain :

Collecting jsbeautifier (from py_package->-r local_requirements.txt (line 1))
   Downloading jsbeautifier-1.7.0.tar.gz
     Complete output from command python setup.py egg_info:
     Traceback (most recent call last):
       File "<string>", line 1, in <module>
       File "/tmp/pip-build-_oun2mqe/jsbeautifier/setup.py", line 6, in <module>
         from jsbeautifier.__version__ import __version__
       File "/tmp/pip-build-_oun2mqe/jsbeautifier/jsbeautifier/__init__.py", line 11, in <module>
         from jsbeautifier.javascript.options import BeautifierOptions
ModuleNotFoundError: No module named 'jsbeautifier.javascript'
----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-_oun2mqe/jsbeautifier/

And, well, it seems to be right, I can't find any trace of javascript.py file anywhere in the source release.

When I look at the setup.py, I can guess the problem, you forgot to add 'jsbeautifier.javascript' to the list of packages, so setup.py won't bring it when making the archive.

Maybe with this it will be better


      packages=['jsbeautifier', 'jsbeautifier.tests', 'jsbeautifier.tests.generated',
                'jsbeautifier.unpackers', 'jsbeautifier.unpackers.tests', 'jsbeautifer.javascript'],
@wssgcg1213
Copy link

wssgcg1213 commented Sep 18, 2017

+1 same problem

@bitwiseman
Copy link
Member

@sladedals - Thanks for the detailed bug report.

@bitwiseman
Copy link
Member

See #1254. Tests will be implemented to protect against this in the future.

@bitwiseman bitwiseman added this to the v1.7.3 milestone Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants