Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip doesn't use same version as /usr/bin/env python #1312

Closed
jyn514 opened this issue Dec 28, 2017 · 0 comments
Closed

pip doesn't use same version as /usr/bin/env python #1312

jyn514 opened this issue Dec 28, 2017 · 0 comments

Comments

@jyn514
Copy link
Contributor

jyn514 commented Dec 28, 2017

Description

All the tests in tools/builds.sh fail if /usr/bin/env python uses a different version from pip.

Relevant code

In tools/build.sh:

build_py()
{
        echo Building python module...
        pip install -e ./python || exit 1
}

Solution

Change pip to /usr/bin/env python -m pip. This will either succeed or throw an error in all use cases, instead of silently installing for the wrong version.

Note

I know, having different system-wide python from user python is never a good idea. It's an easy fix, though, and I find python2 irritating.

jyn514 added a commit to jyn514/js-beautify that referenced this issue Dec 28, 2017
@bitwiseman bitwiseman added this to the v1.7.x milestone Jan 1, 2018
@jyn514 jyn514 changed the title Tests fail if pip doesn't use same version as /usr/bin/env python pip doesn't use same version as /usr/bin/env python Jan 7, 2018
@bitwiseman bitwiseman modified the milestones: v1.7.x, v1.7.6 May 21, 2018
@bitwiseman bitwiseman modified the milestones: v1.8.0-rc2, 1.8.0 Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants