Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note that gsort is GNU sort #1314

Closed
jyn514 opened this issue Dec 28, 2017 · 3 comments
Closed

Note that gsort is GNU sort #1314

jyn514 opened this issue Dec 28, 2017 · 3 comments
Labels
status: needs more info type: bug type: task
Milestone
v1.8.0

Comments

@jyn514
Copy link
Contributor

jyn514 commented Dec 28, 2017 •
edited
Loading

I have sort installed, but because it's not called 'gsort'. Because of this, tools/generate-changelog.sh fails with the following message:

./generate-changelog.sh: line 22: gsort: command not found
Required tool 'gsort' missing.  Failed.

Fix: Add documentation.
@bitwiseman
Copy link
Member

How do you have it installed? I'm working on OSX. Please submit a PR that fixes this for your OS.

@jyn514
Copy link
Contributor Author

jyn514 commented Jan 7, 2018 •
edited
Loading

I'm working on Debian 9 stretch; on my system it's just called sort.

jyn514 added a commit to jyn514/js-beautify that referenced this issue Jan 8, 2018
@jyn514
Add support for GNU Sort being named sort
a77e655 
Closes issue [1314](beautifier#1314).
jyn514 added a commit to jyn514/js-beautify that referenced this issue Jan 8, 2018
@jyn514
Add support for GNU Sort being named sort
857ef02 
Closes issue [1314](beautifier#1314).
@jyn514 jyn514 mentioned this issue Jan 8, 2018
Merged
@jyn514
Copy link
Contributor Author

jyn514 commented Jan 8, 2018 •
edited
Loading

Fixed in #1321

@jyn514 jyn514 closed this as completed Jan 8, 2018
@bitwiseman bitwiseman added this to the v1.7.x milestone Jan 12, 2018
@bitwiseman bitwiseman modified the milestones: v1.7.x, v1.7.6 May 21, 2018
@bitwiseman bitwiseman modified the milestones: v1.8.0-rc2, 1.8.0 Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: needs more info type: bug type: task
Projects
None yet
Milestone
v1.8.0
Development

No branches or pull requests
2 participants
@bitwiseman @jyn514