Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search (ctrl+f) works only in view field in CodeMirror #1696

Closed
oleedd opened this issue Aug 8, 2019 · 2 comments · Fixed by #1713
Closed

Search (ctrl+f) works only in view field in CodeMirror #1696

oleedd opened this issue Aug 8, 2019 · 2 comments · Fixed by #1713

Comments

@oleedd
Copy link

oleedd commented Aug 8, 2019

No such problem in textarea. But CodeMirror is default.
Possible to fix?

@bitwiseman
Copy link
Member

@oleedd
This would require adding the search addon for CodeMirror.
https://codemirror.net/doc/manual.html#addons
Not too hard to fix, just needs someone with time to do it.

@oleedd
Copy link
Author

oleedd commented Aug 12, 2019

It is probably a javascript search in the addon.
CodeMirror is very strange. It rewrites strings according to the view field and deletes lower/higher strings from the html. The search does't work because all strings don't exist in the html at the same time. There seems to be some limit for the number of strings.
Moreover, such behavior requires certain computing power, what doesn't justify the goal - CPU loads up to 60% (i5) during scrolling.
Possible to fix this rewriting and remove these useless calculations to make the standard browser search work as it works in the textarea?

@Hirse Hirse mentioned this issue Oct 7, 2019
6 tasks
@bitwiseman bitwiseman added this to the v1.10.x milestone Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants