Handling of newlines around if/else/if statements

[theshoeshiner]

The handling of an if/else/if block is ambiguous depending on input

With the code on a single line - ie -
if(...){...}else{...}if(...){...}

It will be formatted as such
if (...) {
...
} else {
...
} if (...) {
...
}

Note: No newline between the closure of the else and the second if.
However if there is already a newline after the else{} - ie -
if (...) {...} else {...}
if (...) {...}

Then that newline will be preserved even if preserve newlines is set to false. So the output is -
if (...) {
...
} else {
...
}
if (...) {
...
}

Note: The newline after the else{...}
I dont think this is the expected behavior? With preserve_newlines set to false, the code should always produce the same output (in terms of line breaks), correct?

[bitwiseman]

@dcwatson84 - "With preserve_newlines set to false, the code should always produce the same output (in terms of line breaks), correct?"

Not quite. preserve_newlines is most accurately described as preserve_extra_newlines. The beautifier may still add newlines.

This is still a bug. The output of the first input should be the same as the second.

The test looks like this:

// input
if(x){a();}else{b();}if(y){c();}

// expected
if (x) {
    a();
} else {
    b();
} 
if (y) {
    c();
}
// actual 
if (x) {
    a();
} else {
    b();
} if (y) {
    c();
}

[trusktr]

@bitwiseman How do we make

if(x){a();}else{b();}

result in

if (x) {
    a();
}
else {
    b();
}

where else is on a new line after the } instead of } else {?

[trusktr]

Aha, it seems to be "End braces on own line". Does that correspond to the end-expand brace-style setting? Yes it does.

[trusktr]

Confirmed, I just the encountered the bug of this issue, with a if section not being on it's own line.

[bitwiseman]

So... Bug here or not?

[trusktr]

@bitwiseman I'd say it's a bug.

[trusktr]

// actual 
if (x) {
    a();
} else {
    b();
} if (y) {
    c();
}

I've never seen anyone code like that intentionally. I would always expect if on a new line, like in both of the following examples:

// brace-style == collapse
if (x) {
    a();
} else {
    b();
}
if (y) {
    c();
}

// brace-style == end-expand
if (x) {
    a();
}
else {
    b();
}
if (y) {
    c();
}

[bitwiseman]

Okay, I've tried the above and I'm not getting a repro. In all the cases I tried, the if popped to the next line. Could you open a new issue with the specific input/expected/actual and settings? It is likely your is not the same as this one (regression test in place to cover this one).

[trusktr]

@bitwiseman I've just tried reproducing, and apparently it doesn't happen all the time. If I encounter it again I'll let you know, but it definitely does happen sometimes.