Wrong indent formatting

[mbrammer]

Since some js-beautify or other dependency updates the indent is not working correctly anymore.
Example 1:
Before

(function(global) {
    "use strict";

    /* jshint ignore:start */
    include "somefile.js"
    /* jshint ignore:end */
}(this));

After

(function(global) {
    "use strict";

    /* jshint ignore:start */
    include "somefile.js"
        /* jshint ignore:end */
}(this));

Example 2:
Before

(function(global) {
    "use strict";

    $('#level-up').modal({
        backdrop: 'static'
    })
    .find('.text').toggle(textVisibile).end()
    .find('.table').html(games).end()
    .find('.level').html(user.levelUp.newLevel).end()
    .find('.reward').html(user.levelUp.rewards.coins);
}(this));

After

(function(global) {
    "use strict";
    $('#level-up').modal({
            backdrop: 'static'
        })
        .find('.text').toggle(textVisibile).end()
        .find('.table').html(games).end()
        .find('.level').html(user.levelUp.newLevel).end()
        .find('.reward').html(user.levelUp.rewards.coins);
}(this));

Here is my jsbeautifier config:

jsbeautifier: {
    files: ['js/**/*.js'],
    options: {
        js: {
            braceStyle: "collapse",
            breakChainedMethods: false,
            e4x: false,
            evalCode: false,
            indentChar: " ",
            indentLevel: 0,
            indentSize: 4,
            indentWithTabs: false,
            jslintHappy: false,
            keepArrayIndentation: false,
            keepFunctionIndentation: false,
            preserveNewlines: true,
            maxPreserveNewlines: 2,
            spaceBeforeConditional: true,
            spaceInParen: false,
            unescapeStrings: false,
            wrapLineLength: 0
        }
    }
}

And my package.json.

{
  "devDependencies": {
    "grunt": "~0.4.5",
    "grunt-cli": "~0.1.13",
    "grunt-includes": "~0.4.5",
    "grunt-csscomb": "~3.0.0-1",
    "grunt-jsbeautifier": "~0.2.7",
    "grunt-notify": "~0.3.0",
    "grunt-newer": "~0.8.0",
    "grunt-concurrent": "~1.0.0",
    "grunt-contrib-concat": "~0.5.0",
    "grunt-contrib-copy": "~0.7.0",
    "grunt-contrib-uglify": "~0.6.0",
    "grunt-contrib-sass": "~0.8.1",
    "grunt-contrib-compass": "~1.0.1",
    "grunt-contrib-watch": "~0.6.1",
    "grunt-contrib-jshint": "~0.10.0",
    "grunt-contrib-csslint": "~0.3.1",
    "grunt-contrib-imagemin": "~0.9.1",
    "grunt-contrib-nodeunit": "~0.4.1",
    "grunt-lineending": "~0.2.3",
    "jshint-stylish": "~0.2.0",
    "time-grunt": "~1.0.0"
  }
}

[andyburke]

Also seeing this:

before

    function bindAuthEvent( eventName ) {
        self.auth.on( eventName, function( event, meta ) {
            self.emit( eventName, event, meta );
        } );
    }
    [ 'logged_in', 'logged_out', 'signed_up', 'updated_user' ].forEach( bindAuthEvent );

    function bindBrowserEvent( eventName ) {
        browser.on( eventName, function( event, meta ) {
            self.emit( eventName, event, meta );
        } );
    }
    [ 'navigating' ].forEach( bindBrowserEvent );

after

    function bindAuthEvent( eventName ) {
            self.auth.on( eventName, function( event, meta ) {
                self.emit( eventName, event, meta );
            } );
        }
        [ 'logged_in', 'logged_out', 'signed_up', 'updated_user' ].forEach( bindAuthEvent );

    function bindBrowserEvent( eventName ) {
            browser.on( eventName, function( event, meta ) {
                self.emit( eventName, event, meta );
            } );
        }
        [ 'navigating' ].forEach( bindBrowserEvent );

[andyburke]

Hello?

With this version, js-beautify is basically doing the exact opposite of what it's supposed to do. At least a comment on this issue would be appreciated.

[andyburke]

Could it be related to this?: baf2a34

[bitwiseman]

Hello,
These are very interesting inputs.

Please take each of your formatting errors and file a separate issue for each. I understand you're seeing a bunch of errors, but we'll take them one at a time not as we ball of foo. 😄

[andyburke]

@bitwiseman all of these formatting errors seem related to the same bug. What's the purpose of filing more bugs when these all are probably driven by a single issue with the indenting logic?

[bitwiseman]

@andyburke -
The commit you pointed to is specific to indenting inside the conditional expressions for if(...), for(...), and while(...). Very unlikely to be the cause of these issues.

"probably driven by a single issue with the indenting logic"? Have you looked at the code? There's quite a bit of "indenting logic". While it is possible these are the same issue, a cursory look at your examples indicates to me that that they are likely to be caused by different code paths, thus independent issues.

[andyburke]

I was just trying to be helpful without having to learn your codebase. I looked at recent changes and pointed at what seemed like the most likely one.

As you asked, I have opened a separate issue: #578

I can change the title of that issue to whatever you need it to be. I'm not sure what the case I pointed to is called. Feel free to let me know.

[bitwiseman]

Cool thanks. 😄
Example 1 ... include is an new keyword? Also, if you put a semicolon at the end of the include line it works. The beautifier has a tough time with semicolonless code. Definitely a bug, but might take some time or be part of a larger enhancement.

Example 2: the same as #482. Technically correct for the current design, possible future enhancement.

[bitwiseman]

This may be fixed by f9f6566 .