Made brace_style option more inclusive #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 17, 2017 19:23
* Per specifications at end of beautifier#1058, takes multiple parameters using the last one * Still rejects invalid parameters and rewrites compatible ones
|
This also adds an invalidHandler to |
bitwiseman
approved these changes
Oct 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the discussion of #1058, the
brace_styleoption has been made more inclusive. Also 3 shell tests have been added.expand,collapse,preserve-inlineascollapse,preserve-inlinepreserve-inlineascollapse,preserve-inline(uses the defaultbrace_stylecollapse+ user specifiedpreserve-inline)preserve-inline,collapseaspreserve-inlineinvalid,preserve-line,collapseas invalidWhereas in the previous version these would all reject as invalid.