Minutes vs hours with the built-in timer

[dreeves]

I'm not sure yet if this is a BeemiOS thing or a serverside thing but we got this very sensible feedback / bug report from a user:

Could we make the timer in the iOS app input in minutes rather than something like fraction of a whole day [probably they meant hours]?

The Beedroid timer only does hours (which might be correct and if so it needs to be enforced to avoid confusion, but that's a separate can of worms) but it does display timey goals correctly as HH:MM.

Cognata

• The H.M.S. Parsafore

Verbata: HMS format, hours vs minutes for the timer, floating point hell,

[krugerk]

As is, the timer tracks accumulated seconds. The app contains some logic for treating a goal's units as either minutes or hours:

BeeSwift/BeeSwift/GoalViewController.swift

Lines 336 to 343 in 5be8685

	let hoursRegex = try NSRegularExpression(pattern: "(hr|hour)s?")
	let minutesRegex = try NSRegularExpression(pattern: "(min|minute)s?")
	if hoursRegex.firstMatch(in: self.goal.yAxis, options: [], range: NSMakeRange(0, self.goal.yAxis.count)) != nil {
	controller.units = "hours"
	}
	if minutesRegex.firstMatch(in: self.goal.yAxis, options: [], range: NSMakeRange(0, self.goal.yAxis.count)) != nil {
	controller.units = "minutes"
	}

When submitting to the Beeminder server/backend, the seconds are converted to a decimal number representing either number of minutes or, the default, number of hours:

BeeSwift/BeeSwift/TimerViewController.swift

Lines 168 to 169 in 5be8685

	var value = self.totalSeconds()/3600.0
	if self.units == "minutes" { value = self.totalSeconds()/60.0 }

From the looks of it, the Edit Datapoint VC merely displays the decimal number in a datapoint's value (and does not format it in hour:minute:second):

BeeSwift/BeeSwift/EditDatapointViewController.swift

Line 177 in 5be8685

func textField(_ textField: UITextField, shouldChangeCharactersIn range: NSRange, replacementString string: String) -> Bool {

The section showing the recent datapoints, however, does account for a goal's hhmm setting and uses the format hour:minute in that case:

BeeSwift/BeeSwift/Components/DatapointTableViewController.swift

Lines 90 to 97 in 5be8685

	if hhmmformat {
	let value = datapoint.value.doubleValue
	let hours = Int(value)
	let minutes = Int(value.truncatingRemainder(dividingBy: 1) * 60)
	formattedValue = String(hours) + ":" + String(format: "%02d", minutes)
	} else {
	formattedValue = datapoint.value.stringValue
	}