beet update messes up albumtype tags under Bash for Windows

[light]

Problem

Running beet update inside Git Bash under Windows 10, albumtype and albumtypes are split into single letters :

$ beet update
Some Artist - Some Album - Some Song
  albumtype: soundtrack -> a
  albumtypes: album; soundtrack -> ['a', 'l', 'b', 'u', 'm', ';', ' ', 's', 'o', 'u', 'n', 'd', 't', 'r', 'a', 'c', 'k']

Under PowerShell, I get the same behavior :

PS C:\Users\light> beet update
Some Artist - Some Album - Some Song
  albumtypes: album; soundtrack -> ←[31;01m['←[39;49;00ma←[31;01m', '←[39;49;00ml←[31;01m', '←[39;49;00mb←[31;01m', '←[39;49;00mu←[31;01m', '←[39;49;00mm←[31;01m', '←[39;49;00m;←[31;01m',←[39;49;00m ←[31;01m' ', '←[39;49;00ms←[31;01m', '←[39;49;00mo←[31;01m', '←[39;49;00mu←[31;01m', '←[39;49;00mn←[31;01m', '←[39;49;00md←[31;01m', '←[39;49;00mt←[31;01m', '←[39;49;00mr←[31;01m', '←[39;49;00ma←[31;01m', '←[39;49;00mc←[31;01m', '←[39;49;00mk←[31;01m']←[39;49;00m
  albumtype: ←[31;01msoundtr←[39;49;00ma←[31;01mck←[39;49;00m -> a

Under cmd, I don't see this behavior :

C:\Users\light>beet update

C:\Users\light>

Using cmd however is not really viable since there is no color support and escape sequences are displayed bare (as in PowerShell). Which seems related to that other issue : #2607

Setup

Completely fresh install of beet and basic config, first thing I imported.

$ beet --version
beets version 1.6.0
Python version 3.9.1
no plugins loaded

$ beet config
directory: M:/MP3/sorted
library: M:/MP3/musiclibrary.db

import:
    move: yes

[arsaboo]

I am seeing this in Ubuntu too. Looks like it happens only with album; soundtrack (need to double check this)

Some Artist - Some Album - Some Song
  albumtype: soundtrack -> a
  albumtypes: album; soundtrack -> a; l; b; u; m; ;;  ; s; o; u; n; d; t; r; a; c; k

[pioneerHitesh]

@arsaboo i would like to pick this issue up can you assign this to me?

[arsaboo]

@pioneerHitesh Absolutely... please submit a PR. There is no assignment on beets, but anyone working on this will see your comment.

[pioneerHitesh]

I am seeing this in Ubuntu too. Looks like it happens only with album; soundtrack (need to double check this)

Some Artist - Some Album - Some Song
  albumtype: soundtrack -> a
  albumtypes: album; soundtrack -> a; l; b; u; m; ;;  ; s; o; u; n; d; t; r; a; c; k

@arsaboo This issue is not reproducible on ubuntu shell when deleting a song then running beets update.Can you suggest any specific album where this is happening?

[pioneerHitesh]

@light @arsaboo this issue is not reproducible on windows 11 powershell and git bash.

[arsaboo]

Here's one:

Sukhwinder Singh & Sunidhi Chauhan - Billu Barber - Marjaani (Electro House)
  albumtypes: album; soundtrack -> a; l; b; u; m; ;;  ; s; o; u; n; d; t; r; a; c; k
  albumtype: album -> a

[pioneerHitesh]

@arsaboo i am unable to replicate this issue with windows 11 powershell, git bash version 2.42.0.2 and terminal in ubuntu version 22.04.03 LTS

[arsaboo]

This is excessive:

arsaboo@arsplex:~$ beet info album:"ALBUM"
        albumtype: s
       albumtypes: s; ;;  ; ;; ;;  ;  ; ;;  ; ;; ;;  ; ;; ;;  ;  ; ;;  ;  ; ;;  ; ;; ;;  ;  ; ;;  ; ;; ;;  ; ;; ;;  ;  ; ;;  ; ;; ;;  ; ;; ;;  ;  ; ;;  ;  ; ;;  ; ;; ;;  ;  ; ;;  ;  ; ;;  ; ;; ;;  ;  ; ;;  ; ;; ;;  ; ;; ;;  ;  ; ;;  ;  ; ;;  ; ;; ;;  ;  ; ;;  ; i; ;;  ; ;; ;;  ;  ; ;;  ; ;; ;;  ; ;; ;;  ;  ; ;;  ;  ; ;;  ; ;; ;;  ;  ; ;;  ; ;; ;;  ; ;; ;;  ;  ; ;;  ; ;; ;;  ; ;; ;;  ;  ; ;;  ;  ; ;;  ; ;; ;;  ;  ; ;;  ;  ; ;;  ; ;; ;;  ;  ; ;;  ; ;; ;;  ; ;; ;;  ;  ; ;;  ;  ; ;;  ; ;; ;;  ;  ; ;;  ; n; ;;  ; ;; ;;  ;  ; ;;  ; ;; ;;  ; ;; ;;  ;  ; ;;  ;  ; ;;  ; ;; ;;  ;  ; ;;  ; ;; ;;  ; ;; ;;  ;  ; ;;  ; ;; ;;  ; ;; ;;  ;  ; ;;  ;  ; ;;  ; ;; ;;  ;  ; ;;  ;  ; ;;  ; ;; ;;  ;  ; ;;  ; ;; ;;  ; ;; ;;  ;  ; ;;  ;  ; ;;  ; ;; ;;  ;  ; ;;  ; g; ;;  ; ;; ;;  ;  ; ;;  ; ;; ;;  ; ;; ;;  ;  ; ;;  ;  ; ;;  ; ;; ;;  ;  ; ;;  ; ;; ;;  ; ;; ;;  ;  ; ;;  ; ;; ;;  ; ;; ;;  ;  ; ;;  ;  ; ;;  ; ;; ;;  ;  ; ;;  ;  ; ;;  ; ;; ;;  ;  ; ;;  ; ;; ;;  ; ;; ;;  ;  ; ;;  ;  ; ;;  ; ;; ;;  ;  ; ;;  ; l; ;;  ; ;; ;;  ;  ; ;;  ; ;; ;;  ; ;; ;;  ;  ; ;;  ;  ; ;;  ; ;; ;;  ;  ; ;;  ; ;; ;;  ; ;; ;;  ;  ; ;;  ; ;; ;;  ; ;; ;;  ;  ; ;;  ;  ; ;;  ; ;; ;;  ;  ; ;;  ;  ; ;;  ; ;; ;;  ;  ; ;;  ; ;; ;;  ; ;; ;;  ;  ; ;;  ;  ; ;;  ; ;; ;;  ;  ; ;;  ; e

@sampsyo any thoughts what may be driving it...I am lost here and not sure what/how to fix this.

[sampsyo]

Unfortunately this seems to require some very careful debugging, and I don't have an immediate intuition about the source. I would start with #4582, which purports to have addressed this general issue—and start by ensuring that everyone experiencing it is using a version of the code with that fix?

[JOJ0]

@light as sampsyo suggested: Please try to replicate this issue with the current beets version in development (git master). Thanks!

[JOJ0]

@pioneerHitesh if you want to pick up this issue, please read #4582 as sampsyo suggested, then read #4715 which describes, as far as I understand it, the part of the initial issue that remains to be fixed

[pioneerHitesh]

@JOJ0 will take a look at this and will give it another try.

[arsaboo]

Weirdly enough, I am now seeing some going in the reverse direction after I updated.

  albumtypes: a; ;;  ; ;; ;;  ;  ; ;;  ; ;; ;;  ; ;; ;;  ;  ; ;;  ;  ; ;;  ; ;; ;;  ;  ; ;;  ; l; ;;  ; ;; ;;  ;  ; ;;  ; ;; ;;  ; ;; ;;  ;  ; ;;  ;  ; ;;  ; ;; ;;  ;  ; ;;  ; b; ;;  ; ;; ;;  ;  ; ;;  ; ;; ;;  ; ;; ;;  ;  ; ;;  ;  ; ;;  ; ;; ;;  ;  ; ;;  ; u; ;;  ; ;; ;;  ;  ; ;;  ; ;; ;;  ; ;; ;;  ;  ; ;;  ;  ; ;;  ; ;; ;;  ;  ; ;;  ; m -> album
  albumtype: a -> album

[JOJ0]

Weirdly enough, I am now seeing some going in the reverse direction after I updated.

  albumtypes: a; ;;  ; ;; ;;  ;  ; ;;  ; ;; ;;  ; ;; ;;  ;  ; ;;  ;  ; ;;  ; ;; ;;  ;  ; ;;  ; l; ;;  ; ;; ;;  ;  ; ;;  ; ;; ;;  ; ;; ;;  ;  ; ;;  ;  ; ;;  ; ;; ;;  ;  ; ;;  ; b; ;;  ; ;; ;;  ;  ; ;;  ; ;; ;;  ; ;; ;;  ;  ; ;;  ;  ; ;;  ; ;; ;;  ;  ; ;;  ; u; ;;  ; ;; ;;  ;  ; ;;  ; ;; ;;  ; ;; ;;  ;  ; ;;  ;  ; ;;  ; ;; ;;  ;  ; ;;  ; m -> album

  albumtype: a -> album

Yep, we still haven't fixed this issue. I'm sure you remember ;-)

Happens if you have broken data in the db already.
Here's how to temporarily fix it: #4582 (comment)

[Gremious]

Just wanted to say that this also happened to me on latest (? - 1.6.0) on debian bullseye. I don't think OS matters here.

Brand new user, started importing my library, ~1 folder at a time. After 4-5, I ran beet update to try and fix something, and it happened to me not with soundtrack, but with album; compilation as well as with just album and ep.

I already did the beet write for the fix but I do see it the output of what it fixed:

D3Δ†H H3X - Arcana - PΔRΔMΦUR
  albumtype: a -> album
  albumtypes: ['a', 'l', 'b', 'u', 'm'] -> album

D3Δ†H H3X - King Remixes - King (NOIRE ANTIDOTE remix)
  albumtype: e -> ep
  albumtypes: ['e', 'p'] -> ep

Darkside - Take a Trip, Part 1 - Trumphession
  albumtype: a -> compilation
  albumtypes: ['a', 'l', 'b', 'u', 'm', ';', ' ', 'c', 'o', 'm', 'p', 'i', 'l', 'a', 't', 'i', 'o', 'n'] -> album; compilation

So seemingly, it's any os, and any albumtype

[JOJ0]

@Gremious sorry you got into this. It's partly fixed in git latest beets version. Please upgrade and try fix your library using the steps described here #4582 (comment)

[Gremious]

Yep it's alright, I did that fix just earlier, all is well :)

Good to know it's actually fixed on latest, I will use git version, thanks for the heads up!

[JOJ0]

Duplicate of #4528