Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store user watermark text as a user preference #50

Open
freakboy3742 opened this issue Feb 14, 2020 · 2 comments
Open

Store user watermark text as a user preference #50

freakboy3742 opened this issue Feb 14, 2020 · 2 comments
Labels
enhancement New features, or improvements to existing features.

Comments

@freakboy3742
Copy link
Member

Reported by @okken on Twitter

At present, the default slide deck includes a watermark that says "Made with Podium".

The text can be modified by editing the slide stylesheet; however, this is something that end users will almost always want to customize.

At the very least, editing this text should be documented; but ideally, it should be user configurable - either as a user preference, or as metadata associated with the slide deck.

@freakboy3742 freakboy3742 added enhancement New features, or improvements to existing features. help wanted labels Feb 14, 2020
@paddy-exe
Copy link

Hi @freakboy3742,
I would really love to contribute to podium and solve this issue.
Unfortunately I came across some problems:

  1. I can't understand most of the code because it's quite more complex than the toga examples so maybe you could add some explanation in form of comments/comment sections to the code if possible (this would also help future contributors to understand the code more easily and quicker)
  2. There is (as far as I looked) no python library to parse css flies in the manner of editing as well. So, my proposal would be to add a JavaScript file with a function to edit the css content, add a Preference window to the app (btw there's no documentation in toga for how to do that) and add a text field and a button. The button would call a python function that would call a JavaScript function to edit the css file.

Kind regards and a big thank you for your work

@freakboy3742
Copy link
Member Author

@paddy-exe Thanks for those suggestions. Can't argue that more internal documentation would be beneficial; Podium is essentially a project that has grown over time, rather than being intended as a demo project, so the code isn't necessarily a great .

As for the CSS suggestion - it's not clear to me why a CSS editor or Javascript function is needed here. Most of the customisation that is needed here can be done with templating. A preferences pane, on the other hand, definitely makes sense; adding that to Toga is a long standing feature request (beeware/toga#90).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features, or improvements to existing features.
Projects
None yet
Development

No branches or pull requests

2 participants