Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows ctest failed on native Windows 11 with VS 2022 #70

Open
ClausKlein opened this issue Nov 4, 2024 · 4 comments
Open

Windows ctest failed on native Windows 11 with VS 2022 #70

ClausKlein opened this issue Nov 4, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@ClausKlein
Copy link
Collaborator

ClausKlein commented Nov 4, 2024

C:\Users\KLEIN_CL\Workspace\cpp\execution26>ctest --preset debug --rerun-failed
Test project C:/Users/KLEIN_CL/Workspace/cpp/execution26/build/debug
    Start 19: beman.execution26.exec-just.test
1/1 Test #19: beman.execution26.exec-just.test ...***Failed    3.91 sec
Assertion failed: resource.count == 1u, file C:\Users\KLEIN_CL\Workspace\cpp\execution26\tests\beman\execution26\exec-just.test.cpp, line 184


0% tests passed, 1 tests failed out of 1

Total Test time (real) =   3.92 sec

The following tests FAILED:
         19 - beman.execution26.exec-just.test (Failed)
Errors while running CTest

C:\Users\KLEIN_CL\Workspace\cpp\execution26>

resource.count = 2?

@dietmarkuehl dietmarkuehl added the bug Something isn't working label Nov 5, 2024
@ClausKlein
Copy link
Collaborator Author

ClausKlein commented Nov 5, 2024

I happens also on CI, but there, the CI seems to be blocked without a message at this test?

It happens only with build type Debug, tested in VS 2022?

All other build type are OK.

@ClausKlein
Copy link
Collaborator Author

Rebuild started at 09:54...
1>------ Rebuild All started: Project: ZERO_CHECK, Configuration: Debug x64 ------
1>1>Checking Build System
2>------ Rebuild All started: Project: beman_execution26, Configuration: Debug x64 ------
2>Building Custom Rule C:/Users/KLEIN_CL/Workspace/cpp/execution26/src/beman/execution26/CMakeLists.txt
2>Scanning sources for module dependencies...
2>execution.cpp
2>Compiling...
2>execution.cpp
2>beman_execution26.vcxproj -> C:\Users\KLEIN_CL\Workspace\cpp\execution26\build\src\beman\execution26\Debug\beman_execution26.lib
3>------ Rebuild All started: Project: beman.execution26.exec-just.test, Configuration: Debug x64 ------
3>Building Custom Rule C:/Users/KLEIN_CL/Workspace/cpp/execution26/tests/beman/execution26/CMakeLists.txt
3>Scanning sources for module dependencies...
3>execution.cpp
3>Scanning sources for module dependencies...
3>exec-just.test.cpp
3>Compiling...
3>exec-just.test.cpp
3>beman.execution26.exec-just.test.vcxproj -> C:\Users\KLEIN_CL\Workspace\cpp\execution26\build\tests\beman\execution26\Debug\beman.execution26.exec-just.test.exe
C:\Users\KLEIN_CL\Workspace\cpp\execution26\include\beman\execution26\detail\inplace_stop_source.hpp(132): warning C26110: Caller failing to hold lock 'this->lock' before calling function 'std::unique_lock<std::mutex>::unlock'.
C:\Users\KLEIN_CL\Workspace\cpp\execution26\include\beman\execution26\detail\inplace_stop_source.hpp(137): warning C26117: Releasing unheld lock 'this->lock' in function 'beman::execution26::inplace_stop_source::request_stop'.
C:\Users\KLEIN_CL\Workspace\cpp\execution26\include\beman\execution26\detail\product_type.hpp(78): warning C6031: Return value ignored: 'std::forward'.
C:\Users\KLEIN_CL\Workspace\cpp\execution26\include\beman\execution26\detail\basic_operation.hpp(42): warning C26800: Use of a moved from object: ''(*sender)'' (lifetime.1).
C:\Users\KLEIN_CL\Workspace\cpp\execution26\include\beman\execution26\detail\product_type.hpp(60): warning C6031: Return value ignored: 'std::forward'.
C:\Users\KLEIN_CL\Workspace\cpp\execution26\include\beman\execution26\detail\product_type.hpp(73): warning C6031: Return value ignored: 'std::forward'.
3>Done building project "beman.execution26.exec-just.test.vcxproj".
========== Rebuild All: 3 succeeded, 0 failed, 0 skipped ==========
========== Rebuild completed at 09:54 and took 06,644 seconds ==========

@ClausKlein
Copy link
Collaborator Author

klein_cl@lx005535:~/Workspace/cpp/execution26$ clang-tidy-17 --checks='-*,bug*' -p build/debug tests/beman/execution26/exec-just.test.cpp 
26893 warnings generated.
/home/klein_cl/Workspace/cpp/execution26/include/beman/execution26/detail/forward_like.hpp:22:16: warning: forwarding reference passed to std::move(), which may unexpectedly cause lvalues to be moved; use std::forward() instead [bugprone-move-forwarding-reference]
   22 |         return ::std::move(u);
      |                ^~~~~~~~~~~
      |                ::std::forward<U>
/home/klein_cl/Workspace/cpp/execution26/include/beman/execution26/detail/forward_like.hpp:29:16: warning: forwarding reference passed to std::move(), which may unexpectedly cause lvalues to be moved; use std::forward() instead [bugprone-move-forwarding-reference]
   29 |         return ::std::move(u);
      |                ^~~~~~~~~~~
      |                ::std::forward<U>
/home/klein_cl/Workspace/cpp/execution26/include/beman/execution26/detail/forward_like.hpp:43:16: warning: forwarding reference passed to std::move(), which may unexpectedly cause lvalues to be moved; use std::forward() instead [bugprone-move-forwarding-reference]
   43 |         return ::std::move(u);
      |                ^~~~~~~~~~~
      |                ::std::forward<U>
/home/klein_cl/Workspace/cpp/execution26/include/beman/execution26/detail/stop_source.hpp:209:46: warning: operator=() does not handle self-assignment properly [bugprone-unhandled-self-assignment]
  209 | inline auto beman::execution26::stop_source::operator=(const stop_source& other) -> stop_source& {
      |                                              ^
Suppressed 26889 warnings (26889 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
klein_cl@lx005535:~/Workspace/cpp/execution26$ 

@ClausKlein
Copy link
Collaborator Author

There are more clang-tidy warnings:

klein_cl@lx005535:~/Workspace/cpp/execution26$ clang-tidy-17  -p build/debug tests/beman/execution26/exec-just.test.cpp 
82508 warnings generated.
/home/klein_cl/Workspace/cpp/execution26/include/beman/execution26/detail/basic_sender.hpp:43:10: warning: deleted member function should be public [hicpp-use-equals-delete]
   43 |     auto connect(Receiver receiver) = BEMAN_EXECUTION26_DELETE("the passed receiver doesn't model receiver");
      |          ^
/home/klein_cl/Workspace/cpp/execution26/include/beman/execution26/detail/forward_like.hpp:22:16: warning: forwarding reference passed to std::move(), which may unexpectedly cause lvalues to be moved; use std::forward() instead [bugprone-move-forwarding-reference]
   22 |         return ::std::move(u);
      |                ^~~~~~~~~~~
      |                ::std::forward<U>
/home/klein_cl/Workspace/cpp/execution26/include/beman/execution26/detail/forward_like.hpp:29:16: warning: forwarding reference passed to std::move(), which may unexpectedly cause lvalues to be moved; use std::forward() instead [bugprone-move-forwarding-reference]
   29 |         return ::std::move(u);
      |                ^~~~~~~~~~~
      |                ::std::forward<U>
/home/klein_cl/Workspace/cpp/execution26/include/beman/execution26/detail/forward_like.hpp:43:16: warning: forwarding reference passed to std::move(), which may unexpectedly cause lvalues to be moved; use std::forward() instead [bugprone-move-forwarding-reference]
   43 |         return ::std::move(u);
      |                ^~~~~~~~~~~
      |                ::std::forward<U>
/home/klein_cl/Workspace/cpp/execution26/include/beman/execution26/detail/fwd_env.hpp:21:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [hicpp-explicit-conversions]
   21 |     fwd_env(Env&& env) : env(::std::forward<Env>(env)) {}
      |     ^
      |     explicit 
/home/klein_cl/Workspace/cpp/execution26/include/beman/execution26/detail/inplace_stop_source.hpp:43:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [hicpp-explicit-conversions]
   43 |     inplace_stop_token(::beman::execution26::inplace_stop_source* source) : source(source) {}
      |     ^
      |     explicit 
/home/klein_cl/Workspace/cpp/execution26/include/beman/execution26/detail/inplace_stop_source.hpp:79:27: warning: class 'inplace_stop_callback' defines a non-default destructor and a move constructor but does not define a copy constructor, a copy assignment operator or a move assignment operator [hicpp-special-member-functions]
   79 | class beman::execution26::inplace_stop_callback final
      |                           ^
/home/klein_cl/Workspace/cpp/execution26/include/beman/execution26/detail/operation_state_task.hpp:55:36: warning: class 'operation_state_task' defines a non-default destructor and a move constructor but does not define a copy constructor, a copy assignment operator or a move assignment operator [hicpp-special-member-functions]
   55 | struct beman::execution26::detail::operation_state_task {
      |                                    ^
/home/klein_cl/Workspace/cpp/execution26/include/beman/execution26/detail/run_loop.hpp:27:7: warning: class 'run_loop' defines a non-default destructor and a move constructor but does not define a copy constructor, a copy assignment operator or a move assignment operator [hicpp-special-member-functions]
   27 | class run_loop {
      |       ^
/home/klein_cl/Workspace/cpp/execution26/include/beman/execution26/detail/run_loop.hpp:44:12: warning: class 'opstate' defines a move constructor but does not define a destructor, a copy constructor, a copy assignment operator or a move assignment operator [hicpp-special-member-functions]
   44 |     struct opstate : opstate_base {
      |            ^
/home/klein_cl/Workspace/cpp/execution26/include/beman/execution26/detail/sender_decompose.hpp:16:15: warning: 'operator type-parameter-0-0' must be marked explicit to avoid unintentional implicit conversions [hicpp-explicit-conversions]
   16 |     constexpr operator T() const;
      |               ^
      |               explicit 
/home/klein_cl/Workspace/cpp/execution26/include/beman/execution26/detail/stop_source.hpp:44:36: warning: class 'stop_callback_base' defines a non-default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [hicpp-special-member-functions]
   44 | struct beman::execution26::detail::stop_callback_base {
      |                                    ^
/home/klein_cl/Workspace/cpp/execution26/include/beman/execution26/detail/stop_source.hpp:52:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [hicpp-explicit-conversions]
   52 |     stop_callback_base(const ::beman::execution26::stop_token&);
      |     ^
      |     explicit 
/home/klein_cl/Workspace/cpp/execution26/include/beman/execution26/detail/stop_source.hpp:66:27: warning: class 'stop_source' defines a non-default destructor, a copy constructor and a copy assignment operator but does not define a move constructor or a move assignment operator [hicpp-special-member-functions]
   66 | class beman::execution26::stop_source {
      |                           ^
/home/klein_cl/Workspace/cpp/execution26/include/beman/execution26/detail/stop_source.hpp:96:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [hicpp-explicit-conversions]
   96 |     stop_token(::std::shared_ptr<::beman::execution26::detail::stop_state>);
      |     ^
      |     explicit 
/home/klein_cl/Workspace/cpp/execution26/include/beman/execution26/detail/stop_source.hpp:114:27: warning: class 'stop_callback' defines a non-default destructor and a move constructor but does not define a copy constructor, a copy assignment operator or a move assignment operator [hicpp-special-member-functions]
  114 | class beman::execution26::stop_callback final : private CallbackFun, beman::execution26::detail::stop_callback_base {
      |                           ^
/home/klein_cl/Workspace/cpp/execution26/include/beman/execution26/detail/stop_source.hpp:209:46: warning: operator=() does not handle self-assignment properly [bugprone-unhandled-self-assignment,cert-oop54-cpp]
  209 | inline auto beman::execution26::stop_source::operator=(const stop_source& other) -> stop_source& {
      |                                              ^
/home/klein_cl/Workspace/cpp/execution26/tests/beman/execution26/exec-just.test.cpp:18:8: warning: class 'not_movable' defines a move constructor but does not define a destructor, a copy constructor, a copy assignment operator or a move assignment operator [hicpp-special-member-functions]
   18 | struct not_movable {
      |        ^
/home/klein_cl/Workspace/cpp/execution26/tests/beman/execution26/exec-just.test.cpp:61:8: warning: constructor does not initialize these fields: called [hicpp-member-init]
   61 | struct value_receiver {
      |        ^
   62 |     using receiver_concept = test_std::receiver_t;
   63 |     bool*                                         called;
      |                                                         
      |                                                         {}
Suppressed 82472 warnings (82472 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
klein_cl@lx005535:~/Workspace/cpp/execution26$ 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants